Implement os.openpty

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/test_tagged_unittests.py

@@ -203,7 +203,7 @@ def parse_unittest_output(output):
     # The whole reason for this function's complexity is that we want to consume arbitrary
     # warnings after the '...' part without accidentally consuming the next test result
     import re
-    re_test_result = re.compile(r"""\b(test\S+) \((\S+)\)(?:\n.*?)?? \.\.\. """, re.MULTILINE | re.DOTALL)
+    re_test_result = re.compile(r"""\b(test\S*) \((\S+)\)(?:\n.*?)?? \.\.\. """, re.MULTILINE | re.DOTALL)
     re_test_status = re.compile(r"""\b(ok|skipped (?:'[^']*'|"[^"]*")|FAIL|ERROR)$""", re.MULTILINE | re.DOTALL)
     pos = 0
     current_result = None

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_openpty.txt

@@ -0,0 +1 @@
+*graalpython.lib-python.3.test.test_openpty.OpenptyTest.test

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -115,6 +115,7 @@
 import com.oracle.graal.python.runtime.PosixConstants.IntConstant;
 import com.oracle.graal.python.runtime.PosixSupportLibrary;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Buffer;
+import com.oracle.graal.python.runtime.PosixSupportLibrary.OpenPtyResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PosixException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Timeval;
 import com.oracle.graal.python.runtime.PythonContext;
@@ -689,6 +690,24 @@ Object setsid(VirtualFrame frame,
         }
     }
 
+    @Builtin(name = "openpty")
+    @GenerateNodeFactory
+    public abstract static class OpenPtyNode extends PythonBuiltinNode {
+
+        @Specialization
+        Object openpty(VirtualFrame frame,
+                        @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib) {
+            try {
+                OpenPtyResult result = posixLib.openpty(getPosixSupport());
+                posixLib.setInheritable(getPosixSupport(), result.masterFd(), false);
+                posixLib.setInheritable(getPosixSupport(), result.slaveFd(), false);
+                return factory().createTuple(new int[]{result.masterFd(), result.slaveFd()});
+            } catch (PosixException e) {
+                throw raiseOSErrorFromPosixException(frame, e);
+            }
+        }
+    }
+
     @Builtin(name = "open", minNumOfPositionalArgs = 2, parameterNames = {"path", "flags", "mode"}, keywordOnlyNames = {"dir_fd"})
     @ArgumentClinic(name = "path", conversionClass = PathConversionNode.class, args = {"false", "false"})
     @ArgumentClinic(name = "flags", conversion = ClinicConversion.Int)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/EmulatedPosixSupport.java

@@ -229,6 +229,7 @@
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Inet4SockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Inet6SockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.InvalidAddressException;
+import com.oracle.graal.python.runtime.PosixSupportLibrary.OpenPtyResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PosixException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PwdResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.RecvfromResult;
@@ -2003,6 +2004,12 @@ public long setsid() {
         throw new UnsupportedPosixFeatureException("Emulated getsid not supported");
     }
 
+    @ExportMessage
+    @SuppressWarnings("static-method")
+    public OpenPtyResult openpty() {
+        throw new UnsupportedPosixFeatureException("Emulated openpty not supported");
+    }
+
     @ExportMessage
     @SuppressWarnings("static-method")
     public TruffleString ctermid() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/ImageBuildtimePosixSupport.java

@@ -53,6 +53,7 @@
 import com.oracle.graal.python.runtime.PosixSupportLibrary.FamilySpecificSockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.GetAddrInfoException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.InvalidAddressException;
+import com.oracle.graal.python.runtime.PosixSupportLibrary.OpenPtyResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PosixException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PwdResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.RecvfromResult;
@@ -681,6 +682,12 @@ final long setsid(
         return nativeLib.setsid(nativePosixSupport);
     }
 
+    @ExportMessage
+    final OpenPtyResult openpty(@CachedLibrary("this.nativePosixSupport") PosixSupportLibrary nativeLib) throws PosixException {
+        checkNotInImageBuildtime();
+        return nativeLib.openpty(nativePosixSupport);
+    }
+
     @ExportMessage
     final TruffleString ctermid(@CachedLibrary("this.nativePosixSupport") PosixSupportLibrary nativeLib) throws PosixException {
         checkNotInImageBuildtime();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/LoggingPosixSupport.java

@@ -52,6 +52,7 @@
 import com.oracle.graal.python.runtime.PosixSupportLibrary.FamilySpecificSockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.GetAddrInfoException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.InvalidAddressException;
+import com.oracle.graal.python.runtime.PosixSupportLibrary.OpenPtyResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PosixException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PwdResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.RecvfromResult;
@@ -888,6 +889,16 @@ public int mmapReadBytes(Object mmap, long index, byte[] bytes, int length,
         }
     }
 
+    @ExportMessage
+    final OpenPtyResult openpty(@CachedLibrary("this.delegate") PosixSupportLibrary lib) throws PosixException {
+        logEnter("openpty", "");
+        try {
+            return logExit("openpty", "%s", lib.openpty(delegate));
+        } catch (PosixException e) {
+            throw logException("openpty", e);
+        }
+    }
+
     @ExportMessage
     final TruffleString ctermid(@CachedLibrary("this.delegate") PosixSupportLibrary lib) throws PosixException {
         logEnter("ctermid", "");

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/NFIPosixSupport.java

@@ -85,6 +85,7 @@
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Inet4SockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.Inet6SockAddr;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.InvalidAddressException;
+import com.oracle.graal.python.runtime.PosixSupportLibrary.OpenPtyResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PosixException;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.PwdResult;
 import com.oracle.graal.python.runtime.PosixSupportLibrary.RecvfromResult;
@@ -216,6 +217,7 @@ private enum PosixNativeFunction {
         call_getpgrp("():sint64"),
         call_getsid("(sint64):sint64"),
         call_setsid("():sint64"),
+        call_openpty("([sint32]):sint32"),
         call_ctermid("([sint8]):sint32"),
         call_setenv("([sint8], [sint8], sint32):sint32"),
         call_unsetenv("([sint8]):sint32"),
@@ -1167,6 +1169,16 @@ public long setsid(
         return res;
     }
 
+    @ExportMessage
+    public OpenPtyResult openpty(@Shared("invoke") @Cached InvokeNativeFunction invokeNode) throws PosixException {
+        int[] outvars = new int[2];
+        int res = invokeNode.callInt(this, PosixNativeFunction.call_openpty, wrap(outvars));
+        if (res == -1) {
+            throw getErrnoAndThrowPosixException(invokeNode);
+        }
+        return new OpenPtyResult(outvars[0], outvars[1]);
+    }
+
     @ExportMessage
     public TruffleString ctermid(@Shared("invoke") @Cached InvokeNativeFunction invokeNode,
                     @Shared("tsFromBytes") @Cached TruffleString.FromByteArrayNode fromByteArrayNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PosixSupportLibrary.java

@@ -288,6 +288,11 @@ public abstract class PosixSupportLibrary extends Library {
 
     public abstract long setsid(Object receiver) throws PosixException;
 
+    public record OpenPtyResult(int masterFd, int slaveFd) {
+    }
+
+    public abstract OpenPtyResult openpty(Object receiver) throws PosixException;
+
     public abstract TruffleString ctermid(Object receiver) throws PosixException;
 
     // note: this leaks memory in nfi backend and is not synchronized

graalpython/python-libposix/src/posix.c

@@ -75,6 +75,7 @@
 #include <sys/mman.h>
 #include <unistd.h>
 #include <pwd.h>
+#include <pty.h>
 
 
 int64_t call_getpid() {
@@ -581,6 +582,10 @@ int64_t call_setsid() {
     return setsid();
 }
 
+int32_t call_openpty(int32_t *outvars) {
+    return openpty(outvars, outvars + 1, NULL, NULL, NULL);
+}
+
 int32_t call_ctermid(char *buf) {
     return ctermid(buf) == NULL ? -1 : 0;
 }