allow deletion of function __module__ attribute

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -180,14 +180,14 @@ Object getGlobals(Object self) {
         }
     }
 
-    @Builtin(name = __MODULE__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
+    @Builtin(name = __MODULE__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true, allowsDelete = true)
     @GenerateNodeFactory
     abstract static class GetModuleNode extends PythonBuiltinNode {
         @Specialization(guards = {"!isBuiltinFunction(self)", "isNoValue(none)"})
         Object getModule(VirtualFrame frame, PFunction self, @SuppressWarnings("unused") PNone none,
                         @Cached("create()") ReadAttributeFromObjectNode readObject,
                         @Cached("create()") GetItemNode getItem,
-                        @Cached("create()") WriteAttributeToObjectNode writeObject) {
+                        @Cached.Shared("writeObject") @Cached("create()") WriteAttributeToObjectNode writeObject) {
             Object module = readObject.execute(self, __MODULE__);
             if (module == PNone.NO_VALUE) {
                 CompilerDirectives.transferToInterpreter();
@@ -202,9 +202,16 @@ Object getModule(VirtualFrame frame, PFunction self, @SuppressWarnings("unused")
             return module;
         }
 
-        @Specialization(guards = {"!isBuiltinFunction(self)", "!isNoValue(value)"})
-        Object getModule(PFunction self, Object value,
-                        @Cached("create()") WriteAttributeToObjectNode writeObject) {
+        @Specialization(guards = {"!isBuiltinFunction(self)", "isDeleteMarker(value)"})
+        Object delModule(PFunction self, @SuppressWarnings("unused") Object value,
+                        @Cached.Shared("writeObject") @Cached("create()") WriteAttributeToObjectNode writeObject) {
+            writeObject.execute(self, __MODULE__, PNone.NONE);
+            return PNone.NONE;
+        }
+
+        @Specialization(guards = {"!isBuiltinFunction(self)", "!isNoValue(value)", "!isDeleteMarker(value)"})
+        Object setModule(PFunction self, Object value,
+                        @Cached.Shared("writeObject") @Cached("create()") WriteAttributeToObjectNode writeObject) {
             writeObject.execute(self, __MODULE__, value);
             return PNone.NONE;
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/keywords/KeywordArgumentsNode.java

@@ -95,7 +95,7 @@ PKeyword[] doDict(PKeyword[] arguments, PDict starargs,
 
     protected boolean isNonMapping(PKeyword[] arguments, Object starargs) {
         return (arguments.length == 0 && PGuards.isPNone(starargs)) ||
-                (!PGuards.isDict(starargs) && !PGuards.isPNone(starargs));
+                        (!PGuards.isDict(starargs) && !PGuards.isPNone(starargs));
     }
 
     @Specialization(guards = "arguments.length > 0")

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/positional/ExecutePositionalStarargsNode.java

@@ -61,7 +61,6 @@
 import com.oracle.graal.python.runtime.PythonOptions;
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.graal.python.runtime.exception.PythonErrorType;
-import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
@@ -123,7 +122,7 @@ static Object[] doSet(PSet starargs,
 
     @Specialization
     static Object[] doNone(PNone none,
-                   @Cached PRaiseNode raise) {
+                    @Cached PRaiseNode raise) {
         throw raise.raise(PythonErrorType.TypeError, ErrorMessages.ARG_AFTER_MUST_BE_ITERABLE, none);
     }