Skip to content

Commit 4ccacec

Browse files
committed
Address minor review comments
1 parent 962238c commit 4ccacec

File tree

1 file changed

+4
-5
lines changed
  • graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/hpy

1 file changed

+4
-5
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/hpy/GraalHPyContext.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,8 @@ public GraalHPyContext(PythonContext context, Object hpyLibrary) throws Exceptio
315315
Boolean useNativeFastPaths = language.getEngineOption(PythonOptions.HPyEnableJNIFastPaths);
316316
HPyBackendMode backendMode;
317317
if (!context.getEnv().isNativeAccessAllowed()) {
318-
// TODO(fa): We should just fail and the launcher should set the backend appropriately.
318+
// TODO(fa): We should just fail and the launcher should set the backend appropriately
319+
// (GR-46631).
319320
backendMode = HPyBackendMode.LLVM;
320321
} else {
321322
backendMode = context.getOption(PythonOptions.HPyBackend);
@@ -789,14 +790,12 @@ public abstract static class GetHPyHandleForSingleton extends Node {
789790
public abstract int execute(Object delegateObject);
790791

791792
@Specialization(guards = "isNoValue(x)")
792-
static int doNoValue(PNone x) {
793-
assert x == PNone.NO_VALUE;
793+
static int doNoValue(@SuppressWarnings("unused") PNone x) {
794794
return 0;
795795
}
796796

797797
@Specialization(guards = "!isNoValue(x)")
798-
static int doNone(PNone x) {
799-
assert x == PNone.NONE;
798+
static int doNone(@SuppressWarnings("unused") PNone x) {
800799
return SINGLETON_HANDLE_NONE;
801800
}
802801

0 commit comments

Comments
 (0)