[GR-67249] Address many simple Truffle warnings

Author: eregon

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -2111,7 +2111,7 @@ static Object sumLongIterator(VirtualFrame frame, Node inliningTarget, PLongSequ
 
             @Specialization(guards = "isDouble(start) || isInt(start)")
             static Object sumDoubleIterator(Node inliningTarget, PDoubleSequenceIterator iterator, Object start,
-                            @Cached InlinedConditionProfile startIsDouble,
+                            @Cached @Exclusive InlinedConditionProfile startIsDouble,
                             @Shared @Cached InlinedLoopConditionProfile loopProfilePrimitive) {
                 /*
                  * Need to make sure we keep start type if the iterator was empty

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -2043,7 +2043,7 @@ static long[] bothSpecified(VirtualFrame frame, Object times, Object ns,
         @SuppressWarnings("unused")
         static long[] timesNotATuple(VirtualFrame frame, Object times, PNone ns,
                         @Bind Node inliningTarget,
-                        @Cached PRaiseNode raiseNode) {
+                        @Exclusive @Cached PRaiseNode raiseNode) {
             throw timesTupleError(inliningTarget, raiseNode);
         }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextDictBuiltins.java

@@ -525,7 +525,7 @@ abstract static class PyDict_Merge extends CApiTernaryBuiltinNode {
         static int merge(PDict a, Object b, @SuppressWarnings("unused") int override,
                         @Bind Node inliningTarget,
                         @Shared @Cached PyObjectGetAttr getKeys,
-                        @Cached PyObjectGetAttr getUpdate,
+                        @Exclusive @Cached PyObjectGetAttr getUpdate,
                         @Shared @Cached CallNode callNode,
                         @Cached PRaiseNode raiseNode) {
             // lookup "keys" to raise the right error:

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextErrBuiltins.java

@@ -311,7 +311,7 @@ abstract static class _PyErr_GetHandledException extends CApiUnaryBuiltinNode {
 
         @Specialization
         static Object get(@SuppressWarnings("unused") Object threadState,
-                        @Bind("this") Node inliningTarget,
+                        @Bind Node inliningTarget,
                         @Cached GetCaughtExceptionNode getCaughtExceptionNode,
                         @Cached GetEscapedExceptionNode getEscapedExceptionNode) {
             AbstractTruffleException caughtException = getCaughtExceptionNode.executeFromNative();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/csv/CSVWriterBuiltins.java

@@ -71,6 +71,7 @@
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.GenerateInline;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.NodeFactory;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -207,6 +208,7 @@ static void joinAppend(Node inliningTarget, TruffleStringBuilder sb, CSVWriter s
 
     }
 
+    @GenerateInline(false) // 36 -> 17
     protected abstract static class JoinAppendData extends Node {
 
         abstract boolean execute(Node inliningTarget, TruffleStringBuilder sb, CSVDialect dialect, TruffleString field, boolean quoted, boolean copyPhase,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ctypes/StructureBuiltins.java

@@ -133,7 +133,7 @@ protected abstract static class InitNode extends PythonVarargsBuiltinNode {
         @Specialization
         static Object Struct_init(VirtualFrame frame, CDataObject self, Object[] args, PKeyword[] kwds,
                         @Bind Node inliningTarget,
-                        @Cached("createFor(this)") com.oracle.graal.python.runtime.IndirectCallData indirectCallData,
+                        @Cached("createFor($node)") com.oracle.graal.python.runtime.IndirectCallData indirectCallData,
                         @Cached PyObjectSetAttr setAttr,
                         @Cached GetClassNode getClassNode,
                         @Cached PyObjectGetItem getItemNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/functools/PartialBuiltins.java

@@ -179,7 +179,7 @@ static Object createFromPartialWoDictWoKw(Object cls, Object[] args, PKeyword[]
                         @Exclusive @Cached InlinedConditionProfile hasKeywordsProfile,
                         @Exclusive @SuppressWarnings("unused") @Cached HashingStorageLen lenNode,
                         @Bind PythonLanguage language,
-                        @Cached TypeNodes.GetInstanceShape getInstanceShape) {
+                        @Shared @Cached TypeNodes.GetInstanceShape getInstanceShape) {
             assert args[0] instanceof PPartial;
             final PPartial function = (PPartial) args[0];
             Object[] funcArgs = getNewPartialArgs(function, args, inliningTarget, hasArgsProfile, 1);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/array/ArrayBuiltins.java

@@ -797,7 +797,7 @@ static void setitem(PArray self, PSlice slice, Object other,
                         @Shared @Cached DeleteArraySliceNode deleteSliceNode,
                         @Cached ArrayNodes.ShiftNode shiftNode,
                         @Cached ArrayNodes.SetLengthNode setLengthNode,
-                        @Cached PRaiseNode raiseNode) {
+                        @Exclusive @Cached PRaiseNode raiseNode) {
             int length = self.getLength();
             PSlice.SliceInfo sliceInfo = adjustIndices.execute(inliningTarget, length, sliceUnpack.execute(inliningTarget, slice));
             int start = sliceInfo.start;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/asyncio/GetAwaitableNode.java

@@ -54,6 +54,7 @@
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.dsl.Fallback;
+import com.oracle.truffle.api.dsl.GenerateInline;
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -62,7 +63,7 @@
 
 @GenerateUncached
 @OperationProxy.Proxyable
-@SuppressWarnings("truffle-inlining")
+@GenerateInline(false)
 public abstract class GetAwaitableNode extends Node {
     public abstract Object execute(VirtualFrame frame, Object arg);
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/ByteArrayBuiltins.java

@@ -256,7 +256,7 @@ static void set(VirtualFrame frame, PByteArray self, Object indexObj, Object val
                         @Cached PyNumberAsSizeNode asSizeNode,
                         @Cached("forBytearray()") NormalizeIndexNode normalizeIndexNode,
                         @Cached SequenceStorageNodes.SetItemScalarNode setItemNode,
-                        @Cached PRaiseNode raiseNode) {
+                        @Cached @Exclusive PRaiseNode raiseNode) {
             if (indexCheckNode.execute(inliningTarget, indexObj)) {
                 int index = asSizeNode.executeExact(frame, inliningTarget, indexObj);
                 index = normalizeIndexNode.execute(index, self.getSequenceStorage().length());
@@ -329,7 +329,7 @@ static void doSliceGeneric(VirtualFrame frame, PByteArray self, PSlice slice, Ob
         static void doDelete(VirtualFrame frame, PByteArray self, Object key, @SuppressWarnings("unused") Object value,
                         @Bind Node inliningTarget,
                         @Cached SequenceStorageNodes.DeleteNode deleteNode,
-                        @Cached PRaiseNode raiseNode) {
+                        @Exclusive @Cached PRaiseNode raiseNode) {
             self.checkCanResize(inliningTarget, raiseNode);
             deleteNode.execute(frame, self.getSequenceStorage(), key);
         }