Move error message and use better names

Author: Adam Hrbac

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SysModuleBuiltins.java

@@ -242,7 +242,6 @@
 public class SysModuleBuiltins extends PythonBuiltins {
     private static final TruffleString T_LICENSE = tsLiteral(
                     "Copyright (c) Oracle and/or its affiliates. Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.");
-    private static final TruffleString T_SETTRACE_NOT_IMPLEMENTED = tsLiteral("sys.settrace is only implemented for the bytecode interpreter.");
     private static final String COMPILE_TIME;
     public static final PNone FRAMEWORK = PNone.NONE;
     public static final int MAXSIZE = Integer.MAX_VALUE;
@@ -977,7 +976,7 @@ abstract static class SetTrace extends PythonBuiltinNode {
         Object settrace(Object function) {
             PythonContext ctx = getContext();
             if (!ctx.getOption(PythonOptions.EnableBytecodeInterpreter)) {
-                throw raise(NotImplementedError, T_SETTRACE_NOT_IMPLEMENTED);
+                throw raise(NotImplementedError, ErrorMessages.SETTRACE_NOT_IMPLEMENTED);
             }
             PythonContext.PythonThreadState state = ctx.getThreadState(getLanguage());
             if (function == PNone.NONE) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/frame/FrameBuiltins.java

@@ -158,13 +158,13 @@ int get(PFrame self) {
     @GenerateNodeFactory
     public abstract static class GetTraceNode extends PythonBuiltinNode {
         @Specialization(guards = "isNoValue(v)")
-        static Object doit(PFrame self, @SuppressWarnings("unused") PNone v) {
+        static Object doGet(PFrame self, @SuppressWarnings("unused") PNone v) {
             Object traceFun = self.getLocalTraceFun();
             return traceFun == null ? PNone.NONE : traceFun;
         }
 
         @Specialization(guards = "!isNoValue(v)")
-        static Object doit(PFrame self, Object v) {
+        static Object doSet(PFrame self, Object v) {
             self.setLocalTraceFun(v == PNone.NONE ? null : v);
             return PNone.NONE;
         }
@@ -174,12 +174,12 @@ static Object doit(PFrame self, Object v) {
     @GenerateNodeFactory
     public abstract static class TraceLinesNode extends PythonBuiltinNode {
         @Specialization(guards = "isNoValue(v)")
-        static boolean doit(PFrame self, @SuppressWarnings("unused") PNone v) {
+        static boolean doGet(PFrame self, @SuppressWarnings("unused") PNone v) {
             return self.getTraceLine();
         }
 
         @Specialization(guards = "!isNoValue(v)")
-        static Object doit(PFrame self, boolean v) {
+        static Object doSet(PFrame self, boolean v) {
             self.setTraceLine(v);
             return PNone.NONE;
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/ErrorMessages.java

@@ -1448,4 +1448,6 @@ public abstract class ErrorMessages {
     public static final TruffleString MSG_NOT_SET = tsLiteral("<message not set>");
 
     public static final TruffleString HPY_DEBUG_MODE_NOT_AVAILABLE = tsLiteral("HPy debug mode is not available");
+
+    public static final TruffleString SETTRACE_NOT_IMPLEMENTED = tsLiteral("sys.settrace is only implemented for the bytecode interpreter.");
 }