Document why we don't use IndirectCallContext in ForeignObjectBuiltins and similar

Author: eregon

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/ForeignHashingStorage.java

@@ -68,6 +68,11 @@
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.profiles.InlinedBranchProfile;
 
+/*
+ * NOTE: We are not using IndirectCallContext here in this file because it seems unlikely that these interop messages
+ * would call back to Python and that we would also need precise frame info for that case.
+ * Adding it shouldn't hurt peak, but might be a non-trivial overhead in interpreter.
+ */
 public final class ForeignHashingStorage extends HashingStorage {
 
     public final Object foreignDict;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/ForeignObjectBuiltins.java

@@ -145,6 +145,12 @@
 import com.oracle.truffle.api.profiles.InlinedBranchProfile;
 import com.oracle.truffle.api.strings.TruffleString;
 
+/*
+ * NOTE: We are not using IndirectCallContext here in this file (except for CallNode)
+ * because it seems unlikely that these interop messages would call back to Python
+ * and that we would also need precise frame info for that case.
+ * Adding it shouldn't hurt peak, but might be a non-trivial overhead in interpreter.
+ */
 @CoreFunctions(extendClasses = PythonBuiltinClassType.ForeignObject)
 public final class ForeignObjectBuiltins extends PythonBuiltins {
     public static TpSlots SLOTS = ForeignObjectBuiltinsSlotsGen.SLOTS;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/ForeignSequenceStorage.java

@@ -66,6 +66,11 @@
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.IndexError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 
+/*
+ * NOTE: We are not using IndirectCallContext here in this file because it seems unlikely that these interop messages
+ * would call back to Python and that we would also need precise frame info for that case.
+ * Adding it shouldn't hurt peak, but might be a non-trivial overhead in interpreter.
+ */
 public final class ForeignSequenceStorage extends SequenceStorage {
 
     private final Object foreignArray;