add assertion that first element in handle table actually fits in a jsize

timfel · timfel · commit 54bc9e3b98df · 2023-07-12T14:46:56.000+02:00
diff --git a/graalpython/com.oracle.graal.python.jni/src/hpy_jni.c b/graalpython/com.oracle.graal.python.jni/src/hpy_jni.c
@@ -104,7 +104,9 @@ static int32_t unclosedHandleTop = 0;
 static HPy unclosedHandles[MAX_UNCLOSED_HANDLES];
 
 static inline jsize get_handle_table_size(HPyContext *ctx) {
-    return (jsize)HANDLE_TABLE_SIZE(ctx->_private);
+    uint64_t size = HANDLE_TABLE_SIZE(ctx->_private);
+    assert((jsize)size == size);
+    return (jsize)size;
 }
 
 static uint64_t get_hpy_handle_for_object(HPyContext *ctx, jobject hpyContext, jobject element, bool update_native_cache) {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,9 @@ static int32_t unclosedHandleTop = 0;`
`104`	`104`	`static HPy unclosedHandles[MAX_UNCLOSED_HANDLES];`
`105`	`105`
`106`	`106`	`static inline jsize get_handle_table_size(HPyContext *ctx) {`
`107`		`- return (jsize)HANDLE_TABLE_SIZE(ctx->_private);`
	`107`	`+ uint64_t size = HANDLE_TABLE_SIZE(ctx->_private);`
	`108`	`+ assert((jsize)size == size);`
	`109`	`+ return (jsize)size;`
`108`	`110`	`}`
`109`	`111`
`110`	`112`	`static uint64_t get_hpy_handle_for_object(HPyContext *ctx, jobject hpyContext, jobject element, bool update_native_cache) {`