Skip to content

Commit 5e9df0c

Browse files
committed
Fix isnumeric
1 parent ad5a4b2 commit 5e9df0c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_unicode.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isdecimal
4949
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isdigit
5050
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_islower
51+
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isnumeric
5152
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isprintable
5253
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isspace
5354
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_issue28598_strsubclass_rhs

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1795,7 +1795,8 @@ protected String getName() {
17951795
abstract static class IsNumericNode extends IsCategoryBaseNode {
17961796
@Override
17971797
protected boolean isCategory(int codePoint) {
1798-
return UCharacter.hasBinaryProperty(codePoint, UProperty.NUMERIC_TYPE);
1798+
int numericType = UCharacter.getIntPropertyValue(codePoint, UProperty.NUMERIC_TYPE);
1799+
return numericType == UCharacter.NumericType.DECIMAL || numericType == UCharacter.NumericType.DIGIT || numericType == UCharacter.NumericType.NUMERIC;
17991800
}
18001801

18011802
@Override

0 commit comments

Comments
 (0)