Skip to content

Commit 5fe3e20

Browse files
committed
[GR-12551] Enable custom locals and inheriting locals during exec
PullRequest: graalpython/285
2 parents 5a46493 + 3acb7a3 commit 5fe3e20

27 files changed

+1056
-210
lines changed

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/grammar/TestParserTranslator.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,12 @@
7676
import com.oracle.graal.python.nodes.expression.OrNode;
7777
import com.oracle.graal.python.nodes.expression.TernaryArithmetic;
7878
import com.oracle.graal.python.nodes.expression.UnaryArithmetic;
79-
import com.oracle.graal.python.nodes.frame.DeleteGlobalNode;
79+
import com.oracle.graal.python.nodes.frame.DeleteNameNode;
8080
import com.oracle.graal.python.nodes.frame.DestructuringAssignmentNode;
8181
import com.oracle.graal.python.nodes.frame.FrameSlotIDs;
82-
import com.oracle.graal.python.nodes.frame.ReadGlobalOrBuiltinNode;
83-
import com.oracle.graal.python.nodes.frame.WriteGlobalNode;
82+
import com.oracle.graal.python.nodes.frame.ReadNameNode;
8483
import com.oracle.graal.python.nodes.frame.WriteLocalVariableNode;
84+
import com.oracle.graal.python.nodes.frame.WriteNameNode;
8585
import com.oracle.graal.python.nodes.frame.WriteNode;
8686
import com.oracle.graal.python.nodes.function.FunctionDefinitionNode;
8787
import com.oracle.graal.python.nodes.function.GeneratorExpressionNode;
@@ -265,21 +265,21 @@ public void parseLiteralString() {
265265

266266
@Test
267267
public void parseGlobalVariable() {
268-
parseAs("foobar13_ddsA", ReadGlobalOrBuiltinNode.class);
268+
parseAs("foobar13_ddsA", ReadNameNode.class);
269269
}
270270

271271
@Test
272272
public void parsePropertyAccess() {
273273
parseAs("foobar13_ddsA.property", GetAttributeNode.class);
274274
GetAttributeNode anotherProperty = parseAs("foobar13_ddsA.property.anotherProperty", GetAttributeNode.class);
275275
GetAttributeNode property = assertInstanceOf(anotherProperty.getObject(), GetAttributeNode.class);
276-
assertInstanceOf(property.getObject(), ReadGlobalOrBuiltinNode.class);
276+
assertInstanceOf(property.getObject(), ReadNameNode.class);
277277
}
278278

279279
@Test
280280
public void parseSubscript() {
281281
GetItemNode node = parseAs("foobar[1]", GetItemNode.class);
282-
assertInstanceOf(node.getLeftNode(), ReadGlobalOrBuiltinNode.class);
282+
assertInstanceOf(node.getLeftNode(), ReadNameNode.class);
283283
parseAs("foobar[:]", GetItemNode.class);
284284
parseAs("foobar[::]", GetItemNode.class);
285285
parseAs("foobar[1:2:3]", GetItemNode.class);
@@ -312,22 +312,22 @@ public void parseLiteralSpecial() {
312312

313313
@Test
314314
public void parseDelStatement() {
315-
parseAs("del world", DeleteGlobalNode.class);
315+
parseAs("del world", DeleteNameNode.class);
316316
parseAs("del world[0]", DeleteItemNode.class);
317317
parseAs("del world.field", DeleteAttributeNode.class);
318318
}
319319

320320
@Test
321321
public void parseAssignments() {
322-
WriteGlobalNode parseAs = parseAs("a = 1", WriteGlobalNode.class);
322+
WriteNameNode parseAs = parseAs("a = 1", WriteNameNode.class);
323323
assertEquals("a", parseAs.getAttributeId());
324324

325325
SetAttributeNode parseAsField = parseAs("a.b = 1", SetAttributeNode.class);
326326
assertEquals("b", parseAsField.getAttributeId());
327327

328328
parseAs("a[1] = 1", SetItemNode.class);
329329

330-
parseAs = parseAs("a = 1,2", WriteGlobalNode.class);
330+
parseAs = parseAs("a = 1,2", WriteNameNode.class);
331331
assert parseAs.getRhs() instanceof TupleLiteralNode;
332332

333333
parseAs("a,b = 1,2", DestructuringAssignmentNode.class);
@@ -337,11 +337,11 @@ public void parseAssignments() {
337337

338338
@Test
339339
public void parseImport() {
340-
WriteGlobalNode importSet = parseAs("import foo", WriteGlobalNode.class);
340+
WriteNameNode importSet = parseAs("import foo", WriteNameNode.class);
341341
assertEquals("foo", importSet.getAttributeId());
342342
assert importSet.getRhs() instanceof ImportNode.ImportExpression;
343343

344-
importSet = parseAs("import foo as bar", WriteGlobalNode.class);
344+
importSet = parseAs("import foo as bar", WriteNameNode.class);
345345
assertEquals("bar", importSet.getAttributeId());
346346
assert importSet.getRhs() instanceof ImportNode.ImportExpression;
347347

@@ -410,27 +410,27 @@ public void parseBinaryOp() {
410410

411411
@Test
412412
public void parseFuncdef() {
413-
WriteGlobalNode parseAs = parseAs("def fun(): pass", WriteGlobalNode.class);
413+
WriteNameNode parseAs = parseAs("def fun(): pass", WriteNameNode.class);
414414
assertEquals("fun", parseAs.getAttributeId());
415415
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
416416

417-
parseAs = parseAs("def fun(a): pass", WriteGlobalNode.class);
417+
parseAs = parseAs("def fun(a): pass", WriteNameNode.class);
418418
assertEquals("fun", parseAs.getAttributeId());
419419
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
420420

421-
parseAs = parseAs("def fun(a,b=1): pass", WriteGlobalNode.class);
421+
parseAs = parseAs("def fun(a,b=1): pass", WriteNameNode.class);
422422
assertEquals("fun", parseAs.getAttributeId());
423423
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
424424

425-
parseAs = parseAs("def fun(a,b=1,*c): pass", WriteGlobalNode.class);
425+
parseAs = parseAs("def fun(a,b=1,*c): pass", WriteNameNode.class);
426426
assertEquals("fun", parseAs.getAttributeId());
427427
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
428428

429-
parseAs = parseAs("def fun(a,b=1,*c,d=2): pass", WriteGlobalNode.class);
429+
parseAs = parseAs("def fun(a,b=1,*c,d=2): pass", WriteNameNode.class);
430430
assertEquals("fun", parseAs.getAttributeId());
431431
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
432432

433-
parseAs = parseAs("def fun(a,b=1,*c,d=2,**kwargs): pass", WriteGlobalNode.class);
433+
parseAs = parseAs("def fun(a,b=1,*c,d=2,**kwargs): pass", WriteNameNode.class);
434434
assertEquals("fun", parseAs.getAttributeId());
435435
assert parseAs.getRhs() instanceof FunctionDefinitionNode;
436436
}

0 commit comments

Comments
 (0)