regardless of unbuffered IO it is fine to re-use

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java

@@ -164,12 +164,10 @@ protected boolean areOptionsCompatible(OptionValues firstOptions, OptionValues n
     }
 
     private boolean areOptionsCompatibleWithPreinitializedContext(OptionValues firstOptions, OptionValues newOptions) {
-        // Buffered IO was applied during context initialization
         return (areOptionsCompatible(firstOptions, newOptions) &&
-                        firstOptions.get(PythonOptions.UnbufferedIO).equals(newOptions.get(PythonOptions.UnbufferedIO)) &&
                         // we cache WithThread in SysConfigModuleBuiltins
                         firstOptions.get(PythonOptions.WithThread).equals(newOptions.get(PythonOptions.WithThread)) &&
-                        // disabling TRegex has an effect on the _sre Python code that is created
+                        // disabling TRegex has an effect on the _sre Python functions that are dynamically created
                         firstOptions.get(PythonOptions.WithTRegex).equals(newOptions.get(PythonOptions.WithTRegex)));
     }
 

mx.graalpython/mx_graalpython.py

@@ -414,11 +414,6 @@ def graalpython_gate_runner(args, tasks):
             mx.log(launcher)
             mx.run([launcher, "--log.python.level=FINE", "-S", "-c", "print(b'abc'.decode('ascii'))"], out=mx.TeeOutputCapture(out), err=mx.TeeOutputCapture(out))
             assert "Using preinitialized context." in out.data
-            # And test that we can start even if the graalvm was moved and we cannot use a preinitialized context
-            # n.b.: Forcing unbuffered IO is incompatible with the preinitialized context
-            out = mx.OutputCapture()
-            mx.run([launcher, "--log.python.level=FINE", "-u", "-S", "-c", "print(b'abc'.decode('ascii'))"], out=mx.TeeOutputCapture(out), err=mx.TeeOutputCapture(out))
-            assert "Using preinitialized context." not in out.data
 
     with Task('GraalPython GraalVM native embedding', tasks, tags=[GraalPythonTags.svm, GraalPythonTags.graalvm, GraalPythonTags.native_image_embedder]) as task:
         if task: