Refactor: reverse method

Author: horakivo

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java

@@ -1421,10 +1421,111 @@ public abstract static class ReverseNode extends Node {
         static void doEmpty(@SuppressWarnings("unused") EmptySequenceStorage storage) {
         }
 
-        @Specialization(limit = "MAX_BASIC_STORAGES", guards = "storage.getClass() == cachedClass")
-        static void doBasic(BasicSequenceStorage storage,
-                        @Cached("storage.getClass()") Class<? extends BasicSequenceStorage> cachedClass) {
-            cachedClass.cast(storage).reverse();
+        @Specialization
+        static void doIntStorage(IntSequenceStorage storage) {
+            final int length = storage.length();
+            final int[] values = storage.getInternalIntArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    int temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doDoubleStorage(DoubleSequenceStorage storage) {
+            final int length = storage.length();
+            final double[] values = storage.getInternalDoubleArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    double temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doLongStorage(LongSequenceStorage storage) {
+            final int length = storage.length();
+            final long[] values = storage.getInternalLongArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    long temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doByteStorage(ByteSequenceStorage storage) {
+            final int length = storage.length();
+            final byte[] values = storage.getInternalByteArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    byte temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doObjectStorage(ObjectSequenceStorage storage) {
+            final int length = storage.length();
+            final Object[] values = storage.getInternalArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    Object temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doBoolStorage(BoolSequenceStorage storage) {
+            final int length = storage.length();
+            final boolean[] values = storage.getInternalBoolArray();
+            if (length > 0) {
+                int head = 0;
+                int tail = length - 1;
+                int middle = (length - 1) / 2;
+
+                for (; head <= middle; head++, tail--) {
+                    boolean temp = values[head];
+                    values[head] = values[tail];
+                    values[tail] = temp;
+                }
+            }
+        }
+
+        @Specialization
+        static void doMroStorage(MroSequenceStorage storage) {
+            throw CompilerDirectives.shouldNotReachHere();
         }
 
         @Specialization

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/BasicSequenceStorage.java

@@ -36,8 +36,6 @@ public abstract class BasicSequenceStorage extends SequenceStorage {
 
     public abstract void insertItem(int idx, Object value) throws SequenceStoreException;
 
-    public abstract void reverse();
-
     public abstract SequenceStorage copy();
 
     public abstract SequenceStorage generalizeFor(Object value, SequenceStorage other);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/BoolSequenceStorage.java

@@ -130,21 +130,6 @@ private void insertBoolItem(int idx, boolean value) {
         length++;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                boolean temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public Object getIndicativeValue() {
         return false;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/ByteSequenceStorage.java

@@ -158,21 +158,6 @@ public int indexOfInt(int value) {
         return -1;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                byte temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public Object getIndicativeValue() {
         return 0;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/DoubleSequenceStorage.java

@@ -142,21 +142,6 @@ public int indexOfDouble(double value) {
         return -1;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                double temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public Object getIndicativeValue() {
         return .0;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/IntSequenceStorage.java

@@ -142,21 +142,6 @@ public int indexOfInt(int value) {
         return -1;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                int temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public Object getIndicativeValue() {
         return 0;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/LongSequenceStorage.java

@@ -152,21 +152,6 @@ public int indexOfLong(long value) {
         return -1;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                long temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public Object getIndicativeValue() {
         return 0;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/MroSequenceStorage.java

@@ -150,12 +150,6 @@ public void increaseCapacityExactWithCopy(int newCapacity) {
         throw CompilerDirectives.shouldNotReachHere();
     }
 
-    @SuppressWarnings("unused")
-    @Override
-    public void reverse() {
-        throw CompilerDirectives.shouldNotReachHere();
-    }
-
     @Override
     public Object getIndicativeValue() {
         return null;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/sequence/storage/ObjectSequenceStorage.java

@@ -105,21 +105,6 @@ public void increaseCapacityExactWithCopy(int newCapacity) {
         capacity = values.length;
     }
 
-    @Override
-    public void reverse() {
-        if (length > 0) {
-            int head = 0;
-            int tail = length - 1;
-            int middle = (length - 1) / 2;
-
-            for (; head <= middle; head++, tail--) {
-                Object temp = values[head];
-                values[head] = values[tail];
-                values[tail] = temp;
-            }
-        }
-    }
-
     @Override
     public ObjectSequenceStorage generalizeFor(Object value, SequenceStorage other) {
         return this;