Support sending memoryviews to NFI

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ctypes/memory/PointerNodes.java

@@ -18,10 +18,15 @@
 import com.oracle.graal.python.builtins.modules.ctypes.memory.Pointer.Storage;
 import com.oracle.graal.python.builtins.modules.ctypes.memory.Pointer.ZeroStorage;
 import com.oracle.graal.python.builtins.objects.buffer.PythonBufferAccessLibrary;
+import com.oracle.graal.python.builtins.objects.bytes.PBytesLike;
 import com.oracle.graal.python.builtins.objects.cext.PythonNativeVoidPtr;
+import com.oracle.graal.python.builtins.objects.common.SequenceStorageNodes;
+import com.oracle.graal.python.builtins.objects.memoryview.PMemoryView;
 import com.oracle.graal.python.nodes.ErrorMessages;
 import com.oracle.graal.python.nodes.PRaiseNode;
 import com.oracle.graal.python.nodes.util.CastToJavaUnsignedLongNode;
+import com.oracle.graal.python.runtime.sequence.storage.ByteSequenceStorage;
+import com.oracle.graal.python.runtime.sequence.storage.NativeSequenceStorage;
 import com.oracle.graal.python.util.PythonUtils;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.dsl.Cached;
@@ -32,6 +37,8 @@
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.Specialization;
+import com.oracle.truffle.api.interop.InteropLibrary;
+import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.nodes.Node;
 
@@ -602,9 +609,33 @@ static long doPointerArray(Node inliningTarget, MemoryBlock memory, PointerArray
         }
 
         @Specialization
-        static long doMemoryView(MemoryBlock memory, MemoryViewStorage storage, int offset) {
-            // TODO
-            throw CompilerDirectives.shouldNotReachHere("Memoryview not implemented");
+        static long doMemoryView(Node inliningTarget, MemoryBlock memory, MemoryViewStorage storage, int offset,
+                        @CachedLibrary(limit = "1") InteropLibrary ilib,
+                        @Cached(inline = false) SequenceStorageNodes.StorageToNativeNode storageToNativeNode) {
+            PMemoryView mv = storage.memoryView;
+            Object ptr = null;
+            if (mv.getBufferPointer() != null) {
+                ptr = mv.getBufferPointer();
+            } else if (mv.getBuffer() instanceof PBytesLike bytes) {
+                if (bytes.getSequenceStorage() instanceof NativeSequenceStorage nativeSequenceStorage) {
+                    ptr = nativeSequenceStorage.getPtr();
+                }
+                if (bytes.getSequenceStorage() instanceof ByteSequenceStorage byteSequenceStorage) {
+                    NativeSequenceStorage nativeStorage = storageToNativeNode.execute(byteSequenceStorage.getInternalByteArray(), byteSequenceStorage.length());
+                    bytes.setSequenceStorage(nativeStorage);
+                    ptr = nativeStorage.getPtr();
+                }
+            }
+            if (ptr != null && ilib.isPointer(ptr)) {
+                try {
+                    long nativePointer = ilib.asPointer(ptr);
+                    memory.storage = new LongPointerStorage(nativePointer);
+                    return nativePointer + offset;
+                } catch (UnsupportedMessageException e) {
+                    throw CompilerDirectives.shouldNotReachHere(e);
+                }
+            }
+            throw PRaiseNode.raiseUncached(inliningTarget, NotImplementedError, ErrorMessages.MEMORYVIEW_CANNOT_BE_CONVERTED_TO_NATIVE_MEMORY);
         }
     }
 
@@ -619,9 +650,9 @@ public final Object execute(Node inliningTarget, Pointer ptr) {
         protected abstract Object execute(Node inliningTarget, MemoryBlock memory, Storage storage, int offset);
 
         @Specialization
-        static Object doNFIPointer(@SuppressWarnings("unused") MemoryBlock memory, NFIPointerStorage storage, int offset) {
+        static Object doNFIPointer(Node inliningTarget, @SuppressWarnings("unused") MemoryBlock memory, NFIPointerStorage storage, int offset) {
             if (offset != 0) {
-                throw CompilerDirectives.shouldNotReachHere("Invalid offset for a pointer");
+                throw PRaiseNode.raiseUncached(inliningTarget, NotImplementedError, ErrorMessages.CANNOT_APPLY_OFFSET_TO_AN_OBJECT_POINTER);
             }
             return storage.pointer;
         }
@@ -638,8 +669,8 @@ public final long execute(Node inliningTarget, Pointer ptr) {
 
         @Specialization
         @SuppressWarnings("unused")
-        static long doNFIPointer(MemoryBlock memory, NFIPointerStorage storage, int offset) {
-            throw CompilerDirectives.shouldNotReachHere("Cannot convert Object pointer to native");
+        static long doNFIPointer(Node inliningTarget, MemoryBlock memory, NFIPointerStorage storage, int offset) {
+            throw PRaiseNode.raiseUncached(inliningTarget, NotImplementedError, ErrorMessages.CANNOT_CONVERT_OBJECT_POINTER_TO_NATIVE);
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/ErrorMessages.java

@@ -1188,6 +1188,9 @@ public abstract class ErrorMessages {
 
     // ctypes
     public static final TruffleString PASSING_STRUCTS_BY_VALUE_NOT_SUPPORTED = tsLiteral("Passing structs by value is not supported on NFI backend");
+    public static final TruffleString MEMORYVIEW_CANNOT_BE_CONVERTED_TO_NATIVE_MEMORY = tsLiteral("Memoryview cannot be converted to native memory");
+    public static final TruffleString CANNOT_CONVERT_OBJECT_POINTER_TO_NATIVE = tsLiteral("Cannot convert Object pointer to native");
+    public static final TruffleString CANNOT_APPLY_OFFSET_TO_AN_OBJECT_POINTER = tsLiteral("Cannot apply offset to an object pointer");
     public static final TruffleString S_SYMBOL_IS_MISSING = tsLiteral("%s symbol is missing");
     public static final TruffleString PACK_MUST_BE_A_NON_NEGATIVE_INTEGER = tsLiteral("_pack_ must be a non-negative integer");
     public static final TruffleString FIELDS_MUST_BE_A_SEQUENCE_OF_PAIRS = tsLiteral("'_fields_' must be a sequence of pairs");
@@ -1197,7 +1200,6 @@ public abstract class ErrorMessages {
     public static final TruffleString NUMBER_OF_BITS_INVALID_FOR_BIT_FIELD = tsLiteral("number of bits invalid for bit field");
     public static final TruffleString STRUCTURE_OR_UNION_CANNOT_CONTAIN_ITSELF = tsLiteral("Structure or union cannot contain itself");
     public static final TruffleString FIELDS_MUST_BE_A_SEQUENCE_OF_NAME_C_TYPE_PAIRS = tsLiteral("'_fields_' must be a sequence of (name, C type) pairs");
-    public static final TruffleString INTEGER_EXPECTED = tsLiteral("integer expected");
     public static final TruffleString UNDERLYING_BUFFER_IS_NOT_WRITABLE = tsLiteral("underlying buffer is not writable");
     public static final TruffleString UNDERLYING_BUFFER_IS_NOT_C_CONTIGUOUS = tsLiteral("underlying buffer is not C contiguous");
     public static final TruffleString OFFSET_CANNOT_BE_NEGATIVE = tsLiteral("offset cannot be negative");