Fix: generic case of 'FloatNode' did not cover bytes-like objects.

Author: fangerer

graalpython/com.oracle.graal.python.test/src/tests/test_float.py

@@ -94,11 +94,17 @@ def __round__(x, n):
         assert round(C(), a) == a
 
     def test_create(self):
+        class Obj:
+            def __float__(self):
+                return 1.123
+        assert [float(x) for x in [Obj(), b"0.123"]] == [1.123, 0.123]
+
         assert float(99) == 99
         assert float(999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999) == 1e+132
         assert float(b"0.001") == 0.001
         assert float("0.001") == 0.001
 
+
     def test_hex(self):
         data = [
             ('nan', 'nan'),

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -717,15 +717,20 @@ public Object floatFromString(LazyPythonClass cls, String arg) {
         }
 
         @Specialization(guards = "!isNativeClass(cls)")
-        @TruffleBoundary
         public Object floatFromBytes(LazyPythonClass cls, PIBytesLike arg) {
-            double value = convertStringToDouble(new String(getByteArray(arg)));
+            double value = convertBytesToDouble(arg);
             if (isPrimitiveFloat(cls)) {
                 return value;
             }
             return factory().createFloat(cls, value);
         }
 
+        @TruffleBoundary
+        private double convertBytesToDouble(PIBytesLike arg) {
+            double value = convertStringToDouble(new String(getByteArray(arg)));
+            return value;
+        }
+
         // Taken from Jython PyString's atof() method
         // The last statement throw Py.ValueError is modified
         @TruffleBoundary
@@ -785,6 +790,8 @@ public Object floatFromNone(LazyPythonClass cls, @SuppressWarnings("unused") PNo
                 return convertStringToDouble(((PString) obj).getValue());
             } else if (obj instanceof PNone) {
                 return 0.0;
+            } else if (obj instanceof PIBytesLike) {
+                return convertBytesToDouble((PIBytesLike) obj);
             }
             try {
                 return callFloatNode.executeDouble(obj);