Skip to content

Commit 67566f5

Browse files
committed
Revert making PyLongSign an inline node
1 parent 834229c commit 67566f5

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntNodes.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@
5151
import com.oracle.graal.python.util.OverflowException;
5252
import com.oracle.truffle.api.dsl.Cached;
5353
import com.oracle.truffle.api.dsl.Cached.Shared;
54-
import com.oracle.truffle.api.dsl.GenerateCached;
55-
import com.oracle.truffle.api.dsl.GenerateInline;
5654
import com.oracle.truffle.api.dsl.GenerateUncached;
5755
import com.oracle.truffle.api.dsl.Specialization;
5856
import com.oracle.truffle.api.nodes.Node;
@@ -69,10 +67,8 @@ private IntNodes() {
6967
* Equivalent of CPython's {@code _PyLong_Sign}. Return 0 if v is 0, -1 if v < 0, +1 if v > 0.
7068
*/
7169
@GenerateUncached
72-
@GenerateInline
73-
@GenerateCached(false)
7470
public abstract static class PyLongSign extends Node {
75-
public abstract int execute(Node inliningTarget, Object value);
71+
public abstract int execute(Object value);
7672

7773
@Specialization
7874
static int doInt(int value) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/slice/SliceNodes.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ public abstract static class SliceLossyCastToLong extends Node {
466466
public abstract long execute(Node inliningTarget, Object x);
467467

468468
@Specialization(guards = "!isPNone(i)")
469-
static long doGeneric(Node inliningTarget, Object i,
469+
static long doGeneric(Object i,
470470
@Cached PRaiseNode raise,
471471
@Cached PyIndexCheckNode indexCheckNode,
472472
@Cached PyLongSign signNode,
@@ -475,7 +475,7 @@ static long doGeneric(Node inliningTarget, Object i,
475475
try {
476476
return asSizeNode.execute(null, i);
477477
} catch (OverflowException e) {
478-
if (signNode.execute(inliningTarget, i) < 0) {
478+
if (signNode.execute(i) < 0) {
479479
return Long.MIN_VALUE;
480480
}
481481
return Long.MAX_VALUE;

0 commit comments

Comments
 (0)