[GR-30856] Profile the type of the lookup result in LookupSpecialBaseNode.

PullRequest: graalpython/1774

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/SpecialMethodSlot.java

@@ -284,7 +284,7 @@ private static void initializeBuiltinTypeSlotsImpl(PythonCore core) {
                     if (info != null) {
                         typeSlots[slot.ordinal()] = info;
                     }
-                } else if (PythonLanguage.canCache(value)) {
+                } else if (value instanceof BuiltinMethodDescriptor || PythonLanguage.canCache(value)) {
                     typeSlots[slot.ordinal()] = value;
                 }
             }
@@ -673,14 +673,16 @@ public static boolean checkSlotOverrides(PythonCore core) {
                 Object typeValue = slot.getValue(type);
                 if (typeValue != null) {
                     Object klassValue = slot.getValue(klass);
-                    if (typeValue instanceof BuiltinMethodDescriptor) {
-                        if (!(klassValue instanceof PBuiltinFunction) ||
-                                        ((BuiltinMethodDescriptor) typeValue).getFactory() != ((PBuiltinFunction) klassValue).getBuiltinNodeFactory()) {
-                            mismatches.add(type.getName() + "." + slot.getName());
-                        }
-                    } else if (!typeValue.equals(klassValue)) {
-                        mismatches.add(type.getName() + "." + slot.getName());
+                    if (klassValue.equals(typeValue)) {
+                        // values are same: OK
+                        continue;
                     }
+                    if (typeValue instanceof BuiltinMethodDescriptor && klassValue instanceof PBuiltinFunction &&
+                                    ((BuiltinMethodDescriptor) typeValue).getFactory() == ((PBuiltinFunction) klassValue).getBuiltinNodeFactory()) {
+                        // BuiltinMethodDescriptor and matching PBuiltinFunction: OK
+                        continue;
+                    }
+                    mismatches.add(type.getName() + "." + slot.getName());
                 }
             }
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupSpecialBaseNode.java

@@ -52,19 +52,21 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.nodes.Node;
+import com.oracle.truffle.api.profiles.ValueProfile;
 
 public abstract class LookupSpecialBaseNode extends Node {
     @Child LookupInMROBaseNode lookupNode; // this should be initialized by the subclass
     private final boolean ignoreDescriptorException;
     @Child private LookupInheritedAttributeNode lookupGet;
     @Child private CallNode callGet;
+    private final ValueProfile lookupResProfile = ValueProfile.createClassProfile();
 
     LookupSpecialBaseNode(boolean ignoreDescriptorException) {
         this.ignoreDescriptorException = ignoreDescriptorException;
     }
 
     public final Object execute(VirtualFrame frame, Object type, Object receiver) {
-        Object descriptor = lookupNode.execute(type);
+        Object descriptor = lookupResProfile.profile(lookupNode.execute(type));
         if (descriptor == PNone.NO_VALUE || descriptor instanceof PBuiltinFunction || descriptor instanceof PFunction || descriptor instanceof BuiltinMethodDescriptor) {
             // Return unbound to avoid constructing the bound object
             return descriptor;