Remove extra sign from hex, bin, oct for Long.MIN_VALUE

otethal · otethal · commit 69dbbe05ddcd · 2020-07-09T10:15:12.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java
@@ -283,7 +283,7 @@ protected String bigToString(BigInteger x) {
         String doL(long x,
                         @Cached ConditionProfile isMinLong) {
             if (isMinLong.profile(x == Long.MIN_VALUE)) {
-                return buildString(true, bigToString(PInt.longToBigInteger(x)));
+                return buildString(true, bigToString(PInt.longToBigInteger(x).abs()));
             }
             return buildString(x < 0, longToString(Math.abs(x)));
         }

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ protected String bigToString(BigInteger x) {`
`283`	`283`	`String doL(long x,`
`284`	`284`	`@Cached ConditionProfile isMinLong) {`
`285`	`285`	`if (isMinLong.profile(x == Long.MIN_VALUE)) {`
`286`		`- return buildString(true, bigToString(PInt.longToBigInteger(x)));`
	`286`	`+ return buildString(true, bigToString(PInt.longToBigInteger(x).abs()));`
`287`	`287`	`}`
`288`	`288`	`return buildString(x < 0, longToString(Math.abs(x)));`
`289`	`289`	`}`