Skip to content

Commit 6ab3578

Browse files
committed
use ZonedDateTime instead of Calendar
1 parent 49fdbc4 commit 6ab3578

File tree

1 file changed

+6
-17
lines changed
  • graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ssl

1 file changed

+6
-17
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ssl/CertUtils.java

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,12 @@
8686
import java.security.spec.InvalidKeySpecException;
8787
import java.security.spec.InvalidParameterSpecException;
8888
import java.security.spec.PKCS8EncodedKeySpec;
89-
import java.text.SimpleDateFormat;
9089
import java.util.ArrayList;
9190
import java.util.Base64;
92-
import java.util.Calendar;
9391
import java.util.Collection;
9492
import java.util.Collections;
9593
import java.util.Date;
9694
import java.util.List;
97-
import java.util.TimeZone;
9895
import java.util.logging.Level;
9996

10097
import javax.crypto.interfaces.DHPrivateKey;
@@ -110,6 +107,9 @@
110107
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
111108
import com.oracle.truffle.api.TruffleFile;
112109
import com.oracle.truffle.api.nodes.Node;
110+
import java.time.ZoneId;
111+
import java.time.ZonedDateTime;
112+
import java.time.format.DateTimeFormatter;
113113

114114
import sun.security.provider.certpath.OCSP;
115115
import sun.security.util.DerValue;
@@ -210,23 +210,12 @@ private static String getNotBefore(X509Certificate x509Certificate) {
210210
return formatDate(x509Certificate.getNotBefore());
211211
}
212212

213-
private static final SimpleDateFormat DF1 = new SimpleDateFormat("MMM d HH:mm:ss yyyy z");
214-
private static final SimpleDateFormat DF2 = new SimpleDateFormat("MMM dd HH:mm:ss yyyy z");
215-
private static final Calendar CAL = Calendar.getInstance(TimeZone.getTimeZone("GMT"));
216-
static {
217-
DF1.setTimeZone(TimeZone.getTimeZone("GMT"));
218-
DF2.setTimeZone(TimeZone.getTimeZone("GMT"));
219-
}
213+
private static final ZoneId zoneId = ZoneId.of("GMT");
214+
private static final DateTimeFormatter DF = DateTimeFormatter.ofPattern("MMM ppd HH:mm:ss yyyy z");
220215

221216
@TruffleBoundary
222217
private static String formatDate(Date d) {
223-
CAL.setTime(d);
224-
int day = CAL.get(Calendar.DAY_OF_MONTH);
225-
if (day < 10) {
226-
return DF1.format(d);
227-
} else {
228-
return DF2.format(d);
229-
}
218+
return ZonedDateTime.ofInstant(d.toInstant(), zoneId).format(DF);
230219
}
231220

232221
@TruffleBoundary

0 commit comments

Comments
 (0)