PythonContext: add support for caching per context global ids for builtin empty immutable types (i.e., tuple(), frozenset(), etc)

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -53,6 +53,7 @@
 import static com.oracle.graal.python.nodes.BuiltinNames.SETATTR;
 import static com.oracle.graal.python.nodes.BuiltinNames.SUM;
 import static com.oracle.graal.python.nodes.BuiltinNames.__BREAKPOINT__;
+import static com.oracle.graal.python.nodes.HiddenAttributes.ID_KEY;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__NAME__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__INSTANCECHECK__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__LEN__;
@@ -144,7 +145,6 @@
 import com.oracle.truffle.api.nodes.ExplodeLoop;
 import com.oracle.truffle.api.nodes.RootNode;
 import com.oracle.truffle.api.nodes.UnexpectedResultException;
-import com.oracle.truffle.api.object.HiddenKey;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 import com.oracle.truffle.api.source.Source;
 
@@ -637,7 +637,6 @@ public abstract static class IdNode extends PythonBuiltinNode {
          * The next available global id. We reserve space for all integers to be their own id +
          * offset.
          */
-        private static HiddenKey idKey = new HiddenKey("object_id");
 
         @Child private ReadAttributeFromObjectNode readId = null;
         @Child private WriteAttributeToObjectNode writeId = null;
@@ -705,10 +704,10 @@ private Object getId(PythonObject obj) {
                 readId = insert(ReadAttributeFromObjectNode.create());
                 writeId = insert(WriteAttributeToObjectNode.create());
             }
-            Object id = readId.execute(obj, idKey);
+            Object id = readId.execute(obj, ID_KEY);
             if (id == NO_VALUE) {
                 id = getContext().getNextGlobalId();
-                writeId.execute(obj, idKey, id);
+                writeId.execute(obj, ID_KEY, id);
             }
             return id;
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/HiddenAttributes.java

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2018, Oracle and/or its affiliates.
+ *
+ * The Universal Permissive License (UPL), Version 1.0
+ *
+ * Subject to the condition set forth below, permission is hereby granted to any
+ * person obtaining a copy of this software, associated documentation and/or data
+ * (collectively the "Software"), free of charge and under any and all copyright
+ * rights in the Software, and any and all patent rights owned or freely
+ * licensable by each licensor hereunder covering either (i) the unmodified
+ * Software as contributed to or provided by such licensor, or (ii) the Larger
+ * Works (as defined below), to deal in both
+ *
+ * (a) the Software, and
+ * (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
+ *     one is included with the Software (each a "Larger Work" to which the
+ *     Software is contributed by such licensors),
+ *
+ * without restriction, including without limitation the rights to copy, create
+ * derivative works of, display, perform, and distribute the Software and make,
+ * use, sell, offer for sale, import, export, have made, and have sold the
+ * Software and the Larger Work(s), and to sublicense the foregoing rights on
+ * either these or other terms.
+ *
+ * This license is subject to the following condition:
+ *
+ * The above copyright notice and either this complete permission notice or at a
+ * minimum a reference to the UPL must be included in all copies or substantial
+ * portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+package com.oracle.graal.python.nodes;
+
+import com.oracle.truffle.api.object.HiddenKey;
+
+public abstract class HiddenAttributes {
+    public static final HiddenKey ID_KEY = new HiddenKey("object_id");
+}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java

@@ -56,7 +56,16 @@ public class PythonContext {
     private PythonModule mainModule;
     private final PythonCore core;
     private final HashMap<Object, CallTarget> atExitHooks = new HashMap<>();
-    private final AtomicLong globalId = new AtomicLong(Integer.MAX_VALUE * 2 + 4L);
+    private final AtomicLong globalId = new AtomicLong(Integer.MAX_VALUE * 2L + 4L);
+
+    enum PythonBuiltinImmutableType {
+        PFrozenSet,
+        PTuple,
+        PBytes,
+        PString
+    }
+
+    private final long[] emptyImmutableObjectsIdCache = new long[PythonBuiltinImmutableType.values().length];
 
     @CompilationFinal private TruffleLanguage.Env env;
 
@@ -91,6 +100,18 @@ public PythonContext(PythonLanguage language, TruffleLanguage.Env env, PythonCor
         }
     }
 
+    public long getEmptyImmutableObjectGlobalId(PythonBuiltinImmutableType immutableType) {
+        int idx = immutableType.ordinal();
+        if (emptyImmutableObjectsIdCache[idx] == 0) {
+            synchronized (emptyImmutableObjectsIdCache) {
+                if (emptyImmutableObjectsIdCache[idx] == 0) {
+                    emptyImmutableObjectsIdCache[idx] = getNextGlobalId();
+                }
+            }
+        }
+        return emptyImmutableObjectsIdCache[idx];
+    }
+
     public long getNextGlobalId() {
         return globalId.incrementAndGet();
     }