[GR-40306] Temporarily switch to AST interpreter when instrumentation is requested

PullRequest: graalpython/2392

Author: tomasstupka

graalpython/com.oracle.graal.python.shell/src/com/oracle/graal/python/shell/GraalPythonMain.java

@@ -102,6 +102,8 @@ public static void main(String[] args) {
     private String warnOptions = null;
     private String checkHashPycsMode = "default";
 
+    boolean useASTInterpreter = false;
+
     protected static void setStartupTime() {
         if (GraalPythonMain.startupNanoTime == -1) {
             GraalPythonMain.startupNanoTime = System.nanoTime();
@@ -122,6 +124,7 @@ protected List<String> preprocessArguments(List<String> givenArgs, Map<String, S
         List<String> subprocessArgs = new ArrayList<>();
         programArgs = new ArrayList<>();
         boolean posixBackendSpecified = false;
+        boolean toolInstrumentWarning = true;
         for (Iterator<String> argumentIterator = arguments.iterator(); argumentIterator.hasNext();) {
             String arg = argumentIterator.next();
             if (arg.startsWith("-")) {
@@ -192,8 +195,19 @@ protected List<String> preprocessArguments(List<String> givenArgs, Map<String, S
                             }
                             checkHashPycsMode = argumentIterator.next();
                             continue;
+                        case "--use-ast-interpreter":
+                        case "--python.UseASTInterpreter":
+                            useASTInterpreter = true;
+                            continue;
                         default:
-                            if (arg.startsWith("--llvm.") ||
+                            if (argStartsWith(arg, "--agentscript", "--coverage", "--cpusampler", "--cputracer", "--dap",
+                                            "--heap.", "--heapmonitor", "--insight", "--inspect", "--lsp", "--memtracer", "--sandbox.")) {
+                                useASTInterpreter = true;
+                                if (toolInstrumentWarning) {
+                                    toolInstrumentWarning = false;
+                                    System.out.println("WARNING: Switching to AST interpreter due to instruments option " + arg);
+                                }
+                            } else if (arg.startsWith("--llvm.") ||
                                             matchesPythonOption(arg, "CoreHome") ||
                                             matchesPythonOption(arg, "StdLibHome") ||
                                             matchesPythonOption(arg, "CAPI") ||
@@ -520,6 +534,8 @@ private String getExecutable() {
 
     @Override
     protected void launch(Builder contextBuilder) {
+        String cachePrefix = null;
+
         // prevent the use of System.out/err - they are PrintStreams which suppresses exceptions
         contextBuilder.out(new FileOutputStream(FileDescriptor.out));
         contextBuilder.err(new FileOutputStream(FileDescriptor.err));
@@ -547,10 +563,7 @@ protected void launch(Builder contextBuilder) {
                     warnOptions = envWarnOptions + "," + warnOptions;
                 }
             }
-            String cachePrefix = System.getenv("PYTHONPYCACHEPREFIX");
-            if (cachePrefix != null) {
-                contextBuilder.option("python.PyCachePrefix", cachePrefix);
-            }
+            cachePrefix = System.getenv("PYTHONPYCACHEPREFIX");
 
             String encoding = System.getenv("PYTHONIOENCODING");
             if (encoding != null) {
@@ -577,7 +590,6 @@ protected void launch(Builder contextBuilder) {
         contextBuilder.option("python.VerboseFlag", Boolean.toString(verboseFlag));
         contextBuilder.option("python.IsolateFlag", Boolean.toString(isolateFlag));
         contextBuilder.option("python.WarnOptions", warnOptions);
-        contextBuilder.option("python.DontWriteBytecodeFlag", Boolean.toString(dontWriteBytecode));
         if (verboseFlag) {
             contextBuilder.option("log.python.level", "FINE");
         }
@@ -603,6 +615,18 @@ protected void launch(Builder contextBuilder) {
             contextBuilder.option("python.InputFilePath", inputFile);
         }
 
+        if (useASTInterpreter) {
+            contextBuilder.option("python.DontWriteBytecodeFlag", "true");
+            contextBuilder.option("python.PyCachePrefix", "/dev/null");
+            contextBuilder.option("python.EnableBytecodeInterpreter", "false");
+            contextBuilder.option("python.DisableFrozenModules", "true");
+        } else {
+            contextBuilder.option("python.DontWriteBytecodeFlag", Boolean.toString(dontWriteBytecode));
+            if (cachePrefix != null) {
+                contextBuilder.option("python.PyCachePrefix", cachePrefix);
+            }
+        }
+
         if (multiContext) {
             contextBuilder.engine(Engine.newBuilder().allowExperimentalOptions(true).options(enginePolyglotOptions).build());
         }
@@ -655,6 +679,15 @@ private static boolean matchesPythonOption(String arg, String key) {
         return arg.startsWith("--python." + key) || arg.startsWith("--" + key);
     }
 
+    private static boolean argStartsWith(String arg, String... tools) {
+        for (String t : tools) {
+            if (arg.startsWith(t)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     private String getContextOptionIfSetViaCommandLine(String key) {
         if (System.getProperty("polyglot.python." + key) != null) {
             return System.getProperty("polyglot.python." + key);