Skip to content

Commit 6c847d3

Browse files
committed
replace TypeSystemReference used for casting strings with argument clinic
1 parent 80c090e commit 6c847d3

File tree

1 file changed

+11
-5
lines changed
  • graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/module

1 file changed

+11
-5
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/module/ModuleBuiltins.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555

5656
import java.util.List;
5757

58+
import com.oracle.graal.python.annotations.ArgumentClinic;
5859
import com.oracle.graal.python.builtins.Builtin;
5960
import com.oracle.graal.python.builtins.CoreFunctions;
6061
import com.oracle.graal.python.builtins.PythonBuiltinClassType;
@@ -66,6 +67,7 @@
6667
import com.oracle.graal.python.builtins.objects.common.HashingStorageLibrary;
6768
import com.oracle.graal.python.builtins.objects.common.PHashingCollection;
6869
import com.oracle.graal.python.builtins.objects.dict.PDict;
70+
import com.oracle.graal.python.builtins.objects.module.ModuleBuiltinsClinicProviders.ModuleNodeClinicProviderGen;
6971
import com.oracle.graal.python.builtins.objects.object.ObjectBuiltins;
7072
import com.oracle.graal.python.builtins.objects.object.PythonObjectLibrary;
7173
import com.oracle.graal.python.nodes.ErrorMessages;
@@ -75,11 +77,11 @@
7577
import com.oracle.graal.python.nodes.call.CallNode;
7678
import com.oracle.graal.python.nodes.expression.CoerceToBooleanNode;
7779
import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
78-
import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
7980
import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
81+
import com.oracle.graal.python.nodes.function.builtins.PythonClinicBuiltinNode;
8082
import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
83+
import com.oracle.graal.python.nodes.function.builtins.clinic.ArgumentClinicProvider;
8184
import com.oracle.graal.python.nodes.object.IsBuiltinClassProfile;
82-
import com.oracle.graal.python.nodes.truffle.PythonArithmeticTypes;
8385
import com.oracle.graal.python.nodes.util.CannotCastException;
8486
import com.oracle.graal.python.nodes.util.CastToJavaStringNode;
8587
import com.oracle.graal.python.runtime.exception.PException;
@@ -90,7 +92,6 @@
9092
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
9193
import com.oracle.truffle.api.dsl.NodeFactory;
9294
import com.oracle.truffle.api.dsl.Specialization;
93-
import com.oracle.truffle.api.dsl.TypeSystemReference;
9495
import com.oracle.truffle.api.frame.VirtualFrame;
9596
import com.oracle.truffle.api.interop.UnsupportedMessageException;
9697
import com.oracle.truffle.api.library.CachedLibrary;
@@ -108,8 +109,13 @@ protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFa
108109

109110
@Builtin(name = __INIT__, minNumOfPositionalArgs = 2, declaresExplicitSelf = true, parameterNames = {"self", "name", "doc"})
110111
@GenerateNodeFactory
111-
@TypeSystemReference(PythonArithmeticTypes.class)
112-
public abstract static class ModuleNode extends PythonBuiltinNode {
112+
@ArgumentClinic(name = "name", conversion = ArgumentClinic.ClinicConversion.String)
113+
public abstract static class ModuleNode extends PythonClinicBuiltinNode {
114+
@Override
115+
protected ArgumentClinicProvider getArgumentClinic() {
116+
return ModuleNodeClinicProviderGen.INSTANCE;
117+
}
118+
113119
@Specialization(limit = "1")
114120
public PNone module(PythonModule self, String name, Object doc,
115121
@Cached WriteAttributeToObjectNode writeName,

0 commit comments

Comments
 (0)