Skip to content

Commit 6ce65bb

Browse files
committed
Fix: do not mix '--user' and '--prefix'.
1 parent 0b39d41 commit 6ce65bb

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

graalpython/lib-graalpython/modules/ginstall.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -416,10 +416,8 @@ def install_from_url(url, patch=None, extra_opts=[]):
416416
f.write(patch)
417417
system("patch -d %s/%s/ -p1 < %s/%s.patch" % ((tempdir, bare_name)*2))
418418

419-
if "--prefix" in extra_opts:
420-
system("cd %s/%s; %s setup.py install %s" % (tempdir, bare_name, sys.executable, " ".join(extra_opts)))
421-
else:
422-
system("cd %s/%s; %s setup.py install --user %s" % (tempdir, bare_name, sys.executable, " ".join(extra_opts)))
419+
user_arg = "--user" if "--prefix" not in extra_opts else ""
420+
system("cd %s/%s; %s setup.py install %s %s" % (tempdir, bare_name, sys.executable, user_arg, " ".join(extra_opts)))
423421

424422

425423
def install_from_pypi(package, extra_opts=[]):
@@ -457,9 +455,10 @@ def install_from_pypi(package, extra_opts=[]):
457455
else:
458456
xit("Unknown file type: %s" % filename)
459457

460-
status = os.system("cd %s/%s; %s setup.py install --user %s" % (tempdir, dirname, sys.executable, " ".join(extra_opts)))
458+
user_arg = "--user" if "--prefix" not in extra_opts else ""
459+
status = os.system("cd %s/%s; %s setup.py install %s %s" % (tempdir, dirname, sys.executable, user_arg, " ".join(extra_opts)))
461460
if status != 0:
462-
xit("An error occurred trying to run `setup.py install --user'")
461+
xit("An error occurred trying to run `setup.py install %s %s'" % (user_arg, " ".join(extra_opts)))
463462
else:
464463
xit("Package not found: '%s'" % package)
465464

0 commit comments

Comments
 (0)