Skip to content

Commit 6d7083d

Browse files
committed
toString functions are not meant to be PE'd
1 parent c5f0e7e commit 6d7083d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+218
-46
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727

2828
import java.util.HashMap;
2929

30+
import com.oracle.truffle.api.CompilerAsserts;
31+
3032
public enum PythonBuiltinClassType {
3133

3234
TruffleObject(com.oracle.truffle.api.interop.TruffleObject.class, "truffle_object"),
@@ -109,6 +111,7 @@ public enum PythonBuiltinClassType {
109111

110112
@Override
111113
public String toString() {
114+
CompilerAsserts.neverPartOfCompilation();
112115
return shortName;
113116
}
114117

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/PEllipsis.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
*/
3939
package com.oracle.graal.python.builtins.objects;
4040

41+
import com.oracle.truffle.api.CompilerAsserts;
42+
4143
public final class PEllipsis extends PythonAbstractObject {
4244

4345
public static final PEllipsis INSTANCE = new PEllipsis();
@@ -47,6 +49,7 @@ private PEllipsis() {
4749

4850
@Override
4951
public String toString() {
52+
CompilerAsserts.neverPartOfCompilation();
5053
return "Ellipsis";
5154
}
5255

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/PNone.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
*/
2626
package com.oracle.graal.python.builtins.objects;
2727

28+
import com.oracle.truffle.api.CompilerAsserts;
29+
2830
public final class PNone extends PythonAbstractObject {
2931

3032
public static final PNone NONE = new PNone();
@@ -35,6 +37,7 @@ private PNone() {
3537

3638
@Override
3739
public String toString() {
40+
CompilerAsserts.neverPartOfCompilation();
3841
return this == NONE ? "None" : "NoValue";
3942
}
4043

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/PNotImplemented.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
*/
2626
package com.oracle.graal.python.builtins.objects;
2727

28+
import com.oracle.truffle.api.CompilerAsserts;
29+
2830
public final class PNotImplemented extends PythonAbstractObject {
2931

3032
public static final PNotImplemented NOT_IMPLEMENTED = new PNotImplemented();
@@ -34,6 +36,7 @@ private PNotImplemented() {
3436

3537
@Override
3638
public String toString() {
39+
CompilerAsserts.neverPartOfCompilation();
3740
return "NotImplemented";
3841
}
3942

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/array/PCharArray.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.oracle.graal.python.builtins.objects.type.PythonClass;
2929
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
3030
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
31+
import com.oracle.truffle.api.CompilerAsserts;
3132

3233
public final class PCharArray extends PArray {
3334

@@ -81,6 +82,7 @@ public int len() {
8182

8283
@Override
8384
public String toString() {
85+
CompilerAsserts.neverPartOfCompilation();
8486
StringBuilder buf = new StringBuilder();
8587
buf.append("array('c', [");
8688
for (int i = 0; i < array.length - 1; i++) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/array/PDoubleArray.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.oracle.graal.python.builtins.objects.type.PythonClass;
2929
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
3030
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
31+
import com.oracle.truffle.api.CompilerAsserts;
3132

3233
public final class PDoubleArray extends PArray {
3334

@@ -82,6 +83,7 @@ public int len() {
8283

8384
@Override
8485
public String toString() {
86+
CompilerAsserts.neverPartOfCompilation();
8587
StringBuilder buf = new StringBuilder();
8688
buf.append("array('d', [");
8789
for (int i = 0; i < array.length - 1; i++) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/array/PIntArray.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.oracle.graal.python.builtins.objects.type.PythonClass;
2929
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
3030
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
31+
import com.oracle.truffle.api.CompilerAsserts;
3132

3233
public final class PIntArray extends PArray {
3334

@@ -82,6 +83,7 @@ public int len() {
8283

8384
@Override
8485
public String toString() {
86+
CompilerAsserts.neverPartOfCompilation();
8587
StringBuilder buf = new StringBuilder();
8688
buf.append("array('i', [");
8789
for (int i = 0; i < array.length - 1; i++) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/array/PLongArray.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.oracle.graal.python.builtins.objects.type.PythonClass;
2929
import com.oracle.graal.python.runtime.object.PythonObjectFactory;
3030
import com.oracle.graal.python.runtime.sequence.SequenceUtil;
31+
import com.oracle.truffle.api.CompilerAsserts;
3132

3233
public final class PLongArray extends PArray {
3334

@@ -82,6 +83,7 @@ public int len() {
8283

8384
@Override
8485
public String toString() {
86+
CompilerAsserts.neverPartOfCompilation();
8587
StringBuilder buf = new StringBuilder();
8688
buf.append("array('i', [");
8789
for (int i = 0; i < array.length - 1; i++) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/ByteArrayBuiltins.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
import com.oracle.graal.python.runtime.sequence.storage.SequenceStorage;
7373
import com.oracle.graal.python.runtime.sequence.storage.SequenceStoreException;
7474
import com.oracle.truffle.api.CompilerDirectives;
75+
import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
7576
import com.oracle.truffle.api.dsl.Cached;
7677
import com.oracle.truffle.api.dsl.Fallback;
7778
import com.oracle.truffle.api.dsl.GenerateNodeFactory;
@@ -263,6 +264,7 @@ public Object str(PByteArray self) {
263264
@GenerateNodeFactory
264265
public abstract static class ReprNode extends PythonUnaryBuiltinNode {
265266
@Specialization
267+
@TruffleBoundary
266268
public Object repr(PByteArray self) {
267269
return self.toString();
268270
}

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/BytesBuiltins.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import static com.oracle.graal.python.nodes.SpecialMethodNames.__RADD__;
3939
import static com.oracle.graal.python.nodes.SpecialMethodNames.__REPR__;
4040
import static com.oracle.graal.python.nodes.SpecialMethodNames.__RMUL__;
41-
import static com.oracle.graal.python.nodes.SpecialMethodNames.__STR__;
4241
import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
4342

4443
import java.nio.charset.CodingErrorAction;
@@ -179,19 +178,11 @@ public Object mul(Object self, Object other) {
179178
public abstract static class RMulNode extends MulNode {
180179
}
181180

182-
@Builtin(name = __STR__, fixedNumOfArguments = 1)
183-
@GenerateNodeFactory
184-
public abstract static class StrNode extends PythonUnaryBuiltinNode {
185-
@Specialization
186-
public Object str(PBytes self) {
187-
return self.toString();
188-
}
189-
}
190-
191181
@Builtin(name = __REPR__, fixedNumOfArguments = 1)
192182
@GenerateNodeFactory
193183
public abstract static class ReprNode extends PythonUnaryBuiltinNode {
194184
@Specialization
185+
@TruffleBoundary
195186
public Object repr(PBytes self) {
196187
return self.toString();
197188
}

0 commit comments

Comments
 (0)