[GR-51621] Provide stacktrace for unimplemented native CAPI

PullRequest: graalpython/3204

Author: qunaibit

graalpython/com.oracle.graal.python.cext/src/capi.c

@@ -964,11 +964,45 @@ PyAPI_FUNC(int64_t *) GraalPy_get_finalize_capi_pointer_array() {
     return reset_func_ptrs;
 }
 
+#if ((__linux__ && __GNU_LIBRARY__) || __APPLE__)
+
+#include <stdlib.h>
+#include <string.h>
+#include <execinfo.h>
+
+static void print_c_stacktrace() {
+    size_t max_stack_size = 16;
+    void* stack = calloc(sizeof(void*), max_stack_size);
+    if (stack == NULL) {
+        return;
+    }
+
+    size_t stack_size = backtrace(stack, max_stack_size);
+    char** symbols = backtrace_symbols(stack, stack_size);
+    if (symbols == NULL) {
+        free(stack);
+        return;
+    }
+
+	for (size_t i = 0; i < stack_size; i++) {
+		printf ("%s\n", symbols[i]);
+    }
+}
+
+#else
+
+static void print_c_stacktrace() {
+    // other platforms are not supported
+}
+
+#endif
+
 static void unimplemented(const char* name) {
-	printf("Function not implemented in GraalPy: %s\n", name);
+    printf("Native stacktrace:\n");
+    print_c_stacktrace();
 }
 
-#define FUNC_NOT_IMPLEMENTED unimplemented(__func__); exit(-1);
+#define FUNC_NOT_IMPLEMENTED unimplemented(__func__); GraalPyTrufflePrintStacktrace(__func__, "Function not implemented in GraalPy: "); exit(-1);
 
 // {{start CAPI_BUILTINS}}
 #include "capi.gen.c.h"

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextContextBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -46,6 +46,8 @@
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.Pointer;
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObject;
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObjectTransfer;
+import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.VoidNoReturn;
+import static com.oracle.graal.python.runtime.exception.ExceptionUtils.printPythonLikeStackTrace;
 
 import com.oracle.graal.python.PythonLanguage;
 import com.oracle.graal.python.builtins.PythonBuiltinClassType;
@@ -60,6 +62,7 @@
 import com.oracle.graal.python.nodes.call.CallNode;
 import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.runtime.object.PythonObjectFactory;
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -68,6 +71,18 @@
 
 public final class PythonCextContextBuiltins {
 
+    @CApiBuiltin(ret = VoidNoReturn, args = {ConstCharPtrAsTruffleString, ConstCharPtrAsTruffleString}, call = Ignored)
+    abstract static class PyTrufflePrintStacktrace extends CApiBinaryBuiltinNode {
+
+        @Specialization
+        @TruffleBoundary
+        static Object stacktrace(TruffleString where, TruffleString msg) {
+            System.err.println(msg.toJavaStringUncached() + where.toJavaStringUncached());
+            printPythonLikeStackTrace();
+            return 0;
+        }
+    }
+
     @CApiBuiltin(ret = PyObjectTransfer, args = {ConstCharPtrAsTruffleString, PyObject}, call = Direct)
     abstract static class PyContextVar_New extends CApiBinaryBuiltinNode {
         @Specialization

graalpython/lib-graalpython/patches/tensorflow/tensorflow-2.15.0.patch

@@ -272,7 +272,7 @@ index 00000000000..2b3824c8765
 +    ]
 +
 +    BAZEL_ADD_ENV = [
-+        "--repo_env=TF_PYTHON_VERSION=%s" % '3.10',
++        "--repo_env=TF_PYTHON_VERSION=%s" % '3.11',
 +    ]
 +
 +    if args.g:

mx.graalpython/mx_graalpython.py

@@ -221,10 +221,8 @@ def get_jdk():
     return mx.get_jdk()
 
 
-def full_python(args, **kwargs):
+def full_python(args, env=None):
     """Run python from standalone build (unless kwargs are given). Does not build GraalPython sources automatically."""
-    if kwargs:
-        return python(args, **kwargs)
 
     if not any(arg.startswith('--python.WithJavaStacktrace') for arg in args):
         args.insert(0, '--python.WithJavaStacktrace=1')
@@ -258,7 +256,7 @@ def full_python(args, **kwargs):
                  "To build it: mx python-jvm\n" +
                  "Alternatively use: mx python --hosted")
 
-    mx.run([graalpy_path] + args)
+    mx.run([graalpy_path] + args, env=env)
 
 
 def handle_debug_arg(args):
@@ -1088,7 +1086,7 @@ def graalpytest(args):
     if args.python:
         return mx.run([args.python] + cmd_args, nonZeroIsFatal=True, env=env)
     else:
-        return do_run_python(cmd_args, env=env)
+        return full_python(cmd_args, env=env)
 
 
 def _list_graalpython_unittests(paths=None, exclude=None):