Skip to content

Commit 7182079

Browse files
committed
Fix SSL test assumption about minimum available TLS version
1 parent ec5114c commit 7182079

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_ssl.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_load_default_certs_env_windows
4040
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_load_verify_cadata
4141
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_load_verify_locations
42+
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_min_max_version
4243
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_num_tickest
4344
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_options
4445
*graalpython.lib-python.3.test.test_ssl.ContextTests.test_protocol

graalpython/lib-python/3/test/test_ssl.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1249,10 +1249,11 @@ def test_min_max_version(self):
12491249
ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED
12501250
)
12511251

1252+
# XXX GraalVM change - don't assume that TLSv1.1 is the lowest available version, for us it can be TLSv1.2
12521253
ctx.maximum_version = ssl.TLSVersion.MINIMUM_SUPPORTED
12531254
self.assertIn(
12541255
ctx.maximum_version,
1255-
{ssl.TLSVersion.TLSv1, ssl.TLSVersion.SSLv3}
1256+
{ssl.TLSVersion.TLSv1, ssl.TLSVersion.TLSv1_2, ssl.TLSVersion.SSLv3}
12561257
)
12571258

12581259
ctx.minimum_version = ssl.TLSVersion.MAXIMUM_SUPPORTED

0 commit comments

Comments
 (0)