Skip to content

Commit 718b74a

Browse files
committed
Reduce reporting of polymophism in WriteLocalCellNode
1 parent 3a33245 commit 718b74a

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/cell/WriteLocalCellNode.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727

2828
import static com.oracle.graal.python.builtins.objects.PNone.NO_VALUE;
2929

30-
import com.oracle.graal.python.PythonLanguage;
3130
import com.oracle.graal.python.builtins.objects.cell.PCell;
31+
import com.oracle.graal.python.nodes.PNodeWithContext;
3232
import com.oracle.graal.python.nodes.expression.ExpressionNode;
3333
import com.oracle.graal.python.nodes.frame.WriteIdentifierNode;
3434
import com.oracle.graal.python.nodes.statement.StatementNode;
@@ -38,11 +38,10 @@
3838
import com.oracle.truffle.api.dsl.Cached;
3939
import com.oracle.truffle.api.dsl.ImportStatic;
4040
import com.oracle.truffle.api.dsl.NodeChild;
41-
import com.oracle.truffle.api.dsl.ReportPolymorphism;
41+
import com.oracle.truffle.api.dsl.ReportPolymorphism.Megamorphic;
4242
import com.oracle.truffle.api.dsl.Specialization;
4343
import com.oracle.truffle.api.frame.FrameSlot;
4444
import com.oracle.truffle.api.frame.VirtualFrame;
45-
import com.oracle.truffle.api.nodes.Node;
4645
import com.oracle.truffle.api.nodes.NodeInfo;
4746
import com.oracle.truffle.api.profiles.ConditionProfile;
4847

@@ -88,15 +87,10 @@ public Object getIdentifier() {
8887
}
8988

9089
@ImportStatic(PythonOptions.class)
91-
@ReportPolymorphism
92-
abstract static class WriteToCellNode extends Node {
90+
abstract static class WriteToCellNode extends PNodeWithContext {
9391

9492
public abstract void execute(PCell cell, Object value);
9593

96-
protected static Assumption singleContextAssumption() {
97-
return PythonLanguage.getCurrent().singleContextAssumption;
98-
}
99-
10094
@Specialization(guards = "cell == cachedCell", limit = "getAttributeAccessInlineCacheMaxDepth()", assumptions = "singleContextAssumption")
10195
void doWriteCached(@SuppressWarnings("unused") PCell cell, Object value,
10296
@SuppressWarnings("unused") @Cached("singleContextAssumption()") Assumption singleContextAssumption,
@@ -118,6 +112,7 @@ void doWriteCachedAssumption(PCell cell, Object value,
118112
}
119113
}
120114

115+
@Megamorphic
121116
@Specialization(replaces = {"doWriteCached", "doWriteCachedAssumption"})
122117
void doWriteGeneric(PCell cell, Object value) {
123118
if (value == NO_VALUE) {

0 commit comments

Comments
 (0)