Avoid copying in FileIO.write

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/io/FileIOBuiltins.java

@@ -119,7 +119,6 @@
 import com.oracle.graal.python.builtins.modules.io.IONodes.IOMode;
 import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.buffer.PythonBufferAccessLibrary;
-import com.oracle.graal.python.builtins.objects.bytes.BytesNodes;
 import com.oracle.graal.python.builtins.objects.bytes.PBytes;
 import com.oracle.graal.python.builtins.objects.common.SequenceStorageNodes;
 import com.oracle.graal.python.builtins.objects.exception.OSErrorEnum;
@@ -710,40 +709,44 @@ protected ArgumentClinicProvider getArgumentClinic() {
         }
     }
 
-    @Builtin(name = J_WRITE, minNumOfPositionalArgs = 2)
+    @Builtin(name = J_WRITE, minNumOfPositionalArgs = 2, numOfPositionalOnlyArgs = 2, parameterNames = {"$self", "b"})
+    @ArgumentClinic(name = "b", conversion = ArgumentClinic.ClinicConversion.ReadableBuffer)
     @GenerateNodeFactory
-    public abstract static class WriteNode extends PythonBinaryBuiltinNode {
+    public abstract static class WriteNode extends PythonBinaryClinicBuiltinNode {
 
-        @Specialization(guards = {"!self.isClosed()", "self.isWritable()"})
-        static Object write(VirtualFrame frame, PFileIO self, Object data,
+        @Specialization(limit = "3")
+        static Object write(VirtualFrame frame, PFileIO self, Object buffer,
                         @Bind("this") Node inliningTarget,
-                        @Cached BytesNodes.ToBytesNode toBytes,
+                        @CachedLibrary("buffer") PythonBufferAccessLibrary bufferLib,
                         @CachedLibrary("getPosixSupport()") PosixSupportLibrary posixLib,
                         @Cached InlinedBranchProfile errorProfile,
                         @Cached GilNode gil,
-                        @Cached PConstructAndRaiseNode.Lazy constructAndRaiseNode) {
-            byte[] bytes = toBytes.execute(frame, data);
+                        @Cached PConstructAndRaiseNode.Lazy constructAndRaiseNode,
+                        @Cached PRaiseNode.Lazy raiseNode) {
             try {
-                return PosixModuleBuiltins.WriteNode.write(self.getFD(), bytes, bytes.length, inliningTarget, posixLib, errorProfile, gil);
-            } catch (PosixException e) {
-                if (e.getErrorCode() == EAGAIN.getNumber()) {
-                    return PNone.NONE;
+                if (self.isClosed()) {
+                    throw raiseNode.get(inliningTarget).raise(ValueError, IO_CLOSED);
                 }
-                errorProfile.enter(inliningTarget);
-                throw constructAndRaiseNode.get(inliningTarget).raiseOSErrorFromPosixException(frame, e);
+                if (!self.isWritable()) {
+                    throw raiseNode.get(inliningTarget).raise(IOUnsupportedOperation, FILE_NOT_OPEN_FOR_S, "writing");
+                }
+                try {
+                    return PosixModuleBuiltins.WriteNode.write(self.getFD(), bufferLib.getInternalOrCopiedByteArray(buffer), bufferLib.getBufferLength(buffer),
+                                    inliningTarget, posixLib, errorProfile, gil);
+                } catch (PosixException e) {
+                    if (e.getErrorCode() == EAGAIN.getNumber()) {
+                        return PNone.NONE;
+                    }
+                    throw constructAndRaiseNode.get(inliningTarget).raiseOSErrorFromPosixException(frame, e);
+                }
+            } finally {
+                bufferLib.release(buffer);
             }
         }
 
-        @Specialization(guards = {"!self.isClosed()", "!self.isWritable()"})
-        static Object notWritable(@SuppressWarnings("unused") PFileIO self, @SuppressWarnings("unused") Object buf,
-                        @Shared @Cached PRaiseNode raiseNode) {
-            throw raiseNode.raise(IOUnsupportedOperation, FILE_NOT_OPEN_FOR_S, "writing");
-        }
-
-        @Specialization(guards = "self.isClosed()")
-        static Object closedError(@SuppressWarnings("unused") PFileIO self, @SuppressWarnings("unused") Object buf,
-                        @Shared @Cached PRaiseNode raiseNode) {
-            throw raiseNode.raise(ValueError, IO_CLOSED);
+        @Override
+        protected ArgumentClinicProvider getArgumentClinic() {
+            return FileIOBuiltinsClinicProviders.WriteNodeClinicProviderGen.INSTANCE;
         }
     }