[GR-29124] Fixed handling of relative paths, symlinks and errors in emulated chdir()

PullRequest: graalpython/1586

Author: otethal

graalpython/com.oracle.graal.python.test/src/tests/test_posix.py

@@ -388,9 +388,11 @@ class ChdirTests(unittest.TestCase):
 
     def setUp(self):
         self.old_wd = os.getcwd()
+        os.mkdir(TEST_FULL_PATH1)
 
     def tearDown(self):
         os.chdir(self.old_wd)
+        os.rmdir(TEST_FULL_PATH1)
 
     def test_chdir(self):
         os.chdir(TEMP_DIR)
@@ -399,6 +401,27 @@ def test_chdir(self):
         os.chdir(os.fsencode(self.old_wd))
         self.assertEqual(self.old_wd, os.getcwd())
 
+    def test_chdir_relative(self):
+        os.chdir(TEMP_DIR)
+        tmp_dir = os.getcwd()
+        os.chdir(TEST_FILENAME1)
+        self.assertEqual(os.path.join(tmp_dir, TEST_FILENAME1), os.getcwd())
+
+    def test_chdir_relative_symlink(self):
+        os.symlink(TEST_FULL_PATH1, TEST_FULL_PATH2, target_is_directory=True)
+        try:
+            os.chdir(TEMP_DIR)
+            os.chdir(TEST_FILENAME2)
+        finally:
+            os.remove(TEST_FULL_PATH2)
+
+    def test_chdir_not_a_dir(self):
+        os.close(os.open(TEST_FULL_PATH2, os.O_WRONLY | os.O_CREAT))
+        try:
+            self.assertRaises(NotADirectoryError, os.chdir, TEST_FULL_PATH2)
+        finally:
+            os.unlink(TEST_FULL_PATH2)
+
     def test_chdir_fd(self):
         os.chdir(TEMP_DIR)
         with open(self.old_wd, 0) as fd:

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/EmulatedPosixSupport.java

@@ -1013,7 +1013,15 @@ public void fchdir(int fd,
     }
 
     private void chdirStr(String pathStr, BranchProfile errorBranch) throws PosixException {
-        TruffleFile truffleFile = getTruffleFile(pathStr);
+        TruffleFile truffleFile = getTruffleFile(pathStr).getAbsoluteFile();
+        if (!truffleFile.exists()) {
+            errorBranch.enter();
+            throw posixException(OSErrorEnum.ENOENT);
+        }
+        if (!truffleFile.isDirectory()) {
+            errorBranch.enter();
+            throw posixException(OSErrorEnum.ENOTDIR);
+        }
         try {
             context.getEnv().setCurrentWorkingDirectory(truffleFile);
         } catch (IllegalArgumentException ignored) {