more style fixes

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MathModuleBuiltins.java

@@ -683,13 +683,8 @@ public boolean isNan(Object value) {
     @Builtin(name = "isclose", minNumOfArguments = 2, keywordArguments = {"rel_tol", "abs_tol"})
     @GenerateNodeFactory
     public abstract static class IsCloseNode extends PythonBuiltinNode {
-        private double defaultRel() {
-            return 1e-09;
-        }
-
-        private double defaultAbs() {
-            return 0.0;
-        }
+        private static double DEFAULT_REL = 1e-09;
+        private static double DEFAULT_ABS = 0.0;
 
         private boolean isCloseDouble(double a, double b, double rel_tol, double abs_tol) {
             double diff;
@@ -713,18 +708,18 @@ private boolean isCloseDouble(double a, double b, double rel_tol, double abs_tol
         }
 
         @Specialization
-        public boolean isClose(double a, double b, PNone rel_tol, PNone abs_tol) {
-            return isCloseDouble(a, b, defaultRel(), defaultAbs());
+        public boolean isClose(double a, double b, @SuppressWarnings("unused") PNone rel_tol, @SuppressWarnings("unused") PNone abs_tol) {
+            return isCloseDouble(a, b, DEFAULT_REL, DEFAULT_ABS);
         }
 
         @Specialization
-        public boolean isClose(double a, double b, PNone rel_tol, double abs_tol) {
-            return isCloseDouble(a, b, defaultRel(), abs_tol);
+        public boolean isClose(double a, double b, @SuppressWarnings("unused") PNone rel_tol, double abs_tol) {
+            return isCloseDouble(a, b, DEFAULT_REL, abs_tol);
         }
 
         @Specialization
-        public boolean isClose(double a, double b, double rel_tol, PNone abs_tol) {
-            return isCloseDouble(a, b, rel_tol, defaultAbs());
+        public boolean isClose(double a, double b, double rel_tol, @SuppressWarnings("unused") PNone abs_tol) {
+            return isCloseDouble(a, b, rel_tol, DEFAULT_ABS);
         }
 
         @Specialization

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/floats/FloatBuiltins.java

@@ -878,7 +878,7 @@ abstract static class NegNode extends PythonUnaryBuiltinNode {
     @Builtin(name = __GETFORMAT__, fixedNumOfArguments = 2)
     @GenerateNodeFactory
     abstract static class GetFormatNode extends PythonUnaryBuiltinNode {
-        private String getDetectedEndianess() {
+        private static String getDetectedEndianess() {
             try {
                 ByteOrder byteOrder = ByteOrder.nativeOrder();
                 if (byteOrder.equals(ByteOrder.BIG_ENDIAN)) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/frame/FrameBuiltins.java

@@ -198,7 +198,7 @@ Object get(PFrame self) {
     @GenerateNodeFactory
     public abstract static class FrameClearNode extends PythonBuiltinNode {
         @Specialization
-        Object clear(PFrame self) {
+        Object clear(@SuppressWarnings("unused") PFrame self) {
             // TODO: implement me
             // see: https://github.com/python/cpython/blob/master/Objects/frameobject.c#L503
             return PNone.NONE;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

@@ -719,7 +719,7 @@ public PList doSplit(String self, @SuppressWarnings("unused") PNone sep, int max
         }
 
         @Fallback
-        public Object doSplit(Object self, Object sep, Object maxsplit) {
+        public Object doSplit(@SuppressWarnings("unused") Object self, Object sep, @SuppressWarnings("unused") Object maxsplit) {
             throw raise(TypeError, " Can't convert %p object to str implicitly", sep);
         }
 

scripts/py_unittests.sh

@@ -35,8 +35,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-#!/bin/bash
-
 cd "$(dirname $0)"
 cd ..
 UNIT_TESTS_PATH="graalpython/lib-python/3/test/test_*.py"