[GR-21485] Make __text_signature__ writable

PullRequest: graalpython/832

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/test_functions.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 #
 # The Universal Permissive License (UPL), Version 1.0
@@ -243,3 +243,9 @@ def foo(): pass
     new_dict = { "customProp": "hello, world"}
     foo.__dict__ = new_dict
     assert foo.customProp == "hello, world"
+
+
+def test_function_text_signature_writable():
+    def foo(): pass
+    foo.__text_signature__ = 'foo()'
+    assert foo.__text_signature__ == 'foo()'

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -32,6 +32,7 @@
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__GLOBALS__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__MODULE__;
 import static com.oracle.graal.python.nodes.SpecialAttributeNames.__NAME__;
+import static com.oracle.graal.python.nodes.SpecialAttributeNames.__TEXT_SIGNATURE__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__CALL__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__GET__;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.AttributeError;
@@ -58,7 +59,6 @@
 import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonTernaryBuiltinNode;
-import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.subscript.GetItemNode;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
@@ -300,19 +300,37 @@ Object builtinCode(PBuiltinFunction self, Object mapping) {
         }
     }
 
-    @Builtin(name = "__text_signature__", minNumOfPositionalArgs = 1, isGetter = true)
+    @Builtin(name = __TEXT_SIGNATURE__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
     @GenerateNodeFactory
-    public abstract static class TextSignatureNode extends PythonUnaryBuiltinNode {
-        @Specialization
-        protected Object doStatic(@SuppressWarnings("unused") PBuiltinFunction self) {
-            return getSignature(self.getSignature());
+    public abstract static class TextSignatureNode extends PythonBinaryBuiltinNode {
+        @Specialization(guards = {"!isBuiltinFunction(self)", "isNoValue(none)"})
+        Object getFunction(PFunction self, @SuppressWarnings("unused") PNone none,
+                        @Cached("create()") ReadAttributeFromObjectNode readNode) {
+            Object signature = readNode.execute(self, __TEXT_SIGNATURE__);
+            if (signature == PNone.NO_VALUE) {
+                throw raise(AttributeError, "'function' object has no attribute '__text_signature__'");
+            }
+            return signature;
         }
 
-        @Specialization
-        protected Object doStatic(@SuppressWarnings("unused") PFunction self) {
+        @Specialization(guards = {"!isBuiltinFunction(self)", "!isNoValue(value)"})
+        Object setFunction(PFunction self, Object value,
+                        @Cached("create()") WriteAttributeToObjectNode writeNode) {
+            writeNode.execute(self, __TEXT_SIGNATURE__, value);
+            return PNone.NONE;
+        }
+
+        @Specialization(guards = "isNoValue(none)")
+        protected Object getBuiltin(PBuiltinFunction self, @SuppressWarnings("unused") PNone none) {
             return getSignature(self.getSignature());
         }
 
+        @Specialization(guards = "!isNoValue(value)")
+        protected Object setBuiltin(@SuppressWarnings("unused") PBuiltinFunction self,
+                        @SuppressWarnings("unused") Object value) {
+            throw raise(AttributeError, "AttributeError: attribute '__text_signature__' of 'builtin_function_or_method' objects is not writable");
+        }
+
         @TruffleBoundary
         private static Object getSignature(Signature signature) {
             String[] keywordNames = signature.getKeywordNames();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/method/BuiltinMethodBuiltins.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2019, Oracle and/or its affiliates.
+ * Copyright (c) 2017, 2020, Oracle and/or its affiliates.
  * Copyright (c) 2014, Regents of the University of California
  *
  * All rights reserved.
@@ -26,6 +26,7 @@
 
 package com.oracle.graal.python.builtins.objects.method;
 
+import static com.oracle.graal.python.nodes.SpecialAttributeNames.__TEXT_SIGNATURE__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__REDUCE__;
 import static com.oracle.graal.python.nodes.SpecialMethodNames.__REPR__;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
@@ -44,6 +45,7 @@
 import com.oracle.graal.python.nodes.SpecialAttributeNames;
 import com.oracle.graal.python.nodes.attributes.GetAttributeNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
+import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.graal.python.nodes.object.GetLazyClassNode;
 import com.oracle.graal.python.nodes.util.CastToJavaStringNode;
@@ -160,19 +162,19 @@ private PException raiseCannotPickle() {
         }
     }
 
-    @Builtin(name = "__text_signature__", minNumOfPositionalArgs = 1, isGetter = true)
+    @Builtin(name = __TEXT_SIGNATURE__, minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2, isGetter = true, isSetter = true)
     @GenerateNodeFactory
-    public abstract static class TextSignatureNode extends PythonUnaryBuiltinNode {
+    public abstract static class TextSignatureNode extends PythonBinaryBuiltinNode {
         @Child AbstractFunctionBuiltins.TextSignatureNode subNode = AbstractFunctionBuiltins.TextSignatureNode.create();
 
         @Specialization
-        Object getTextSignature(VirtualFrame frame, PBuiltinMethod self) {
-            return subNode.execute(frame, self.getFunction());
+        Object getTextSignature(VirtualFrame frame, PBuiltinMethod self, Object value) {
+            return subNode.execute(frame, self.getFunction(), value);
         }
 
         @Specialization
-        Object getTextSignature(VirtualFrame frame, PMethod self) {
-            return subNode.execute(frame, self.getFunction());
+        Object getTextSignature(VirtualFrame frame, PMethod self, Object value) {
+            return subNode.execute(frame, self.getFunction(), value);
         }
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/SpecialAttributeNames.java

@@ -65,6 +65,7 @@ public abstract class SpecialAttributeNames {
     public static final String __PATH__ = "__path__";
     public static final String __FILE__ = "__file__";
     public static final String __CACHED__ = "__cached__";
+    public static final String __TEXT_SIGNATURE__ = "__text_signature__";
     public static final String __TRACEBACK__ = "__traceback__";
     public static final String __CAUSE__ = "__cause__";
     public static final String __CONTEXT__ = "__context__";