Skip to content

Commit 7827c29

Browse files
committed
[GR-23511] Fix interop contract for some native wrappers.
PullRequest: graalpython/949
2 parents d76c368 + 9d08765 commit 7827c29

File tree

4 files changed

+8
-31
lines changed

4 files changed

+8
-31
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/PThreadState.java

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -285,21 +285,8 @@ protected boolean isMemberModifiable(String member) {
285285
}
286286

287287
@ExportMessage
288-
protected boolean isMemberInsertable(String member) {
289-
// TODO: cbasca, fangerer is this true ?
290-
switch (member) {
291-
case CUR_EXC_TYPE:
292-
case CUR_EXC_VALUE:
293-
case CUR_EXC_TRACEBACK:
294-
case EXC_TYPE:
295-
case EXC_VALUE:
296-
case EXC_TRACEBACK:
297-
case RECURSION_DEPTH:
298-
case OVERFLOWED:
299-
return true;
300-
default:
301-
return false;
302-
}
288+
protected boolean isMemberInsertable(@SuppressWarnings("unused") String member) {
289+
return false;
303290
}
304291

305292
@ExportMessage

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/PyGetSetDefWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ protected boolean isMemberModifiable(String member) {
152152
}
153153

154154
@ExportMessage
155-
protected boolean isMemberInsertable(String member) {
156-
return DOC.equals(member);
155+
protected boolean isMemberInsertable(@SuppressWarnings("unused") String member) {
156+
return false;
157157
}
158158

159159
@ExportMessage

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/PyMemberDefWrapper.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ protected boolean isMemberModifiable(String member) {
150150
}
151151

152152
@ExportMessage
153-
protected boolean isMemberInsertable(String member) {
154-
return member.equals(DOC);
153+
protected boolean isMemberInsertable(@SuppressWarnings("unused") String member) {
154+
return false;
155155
}
156156

157157
@ExportMessage
@@ -166,16 +166,6 @@ protected void writeMember(String member, Object value,
166166
setAttrNode.execute(lib.getDelegate(this), member, fromCharPointerNode.execute(value));
167167
}
168168

169-
@ExportMessage
170-
protected boolean isMemberRemovable(@SuppressWarnings("unused") String member) {
171-
return false;
172-
}
173-
174-
@ExportMessage
175-
protected void removeMember(@SuppressWarnings("unused") String member) throws UnsupportedMessageException {
176-
throw UnsupportedMessageException.create();
177-
}
178-
179169
@ExportMessage
180170
@SuppressWarnings("static-method")
181171
protected boolean hasNativeType() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/PyMethodDescrWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,8 @@ protected boolean isMemberModifiable(String member) {
155155
}
156156

157157
@ExportMessage
158-
protected boolean isMemberInsertable(String member) {
159-
return DOC.equals(member);
158+
protected boolean isMemberInsertable(@SuppressWarnings("unused") String member) {
159+
return false;
160160
}
161161

162162
@ExportMessage

0 commit comments

Comments
 (0)