Move AST class creation to postInitialize

Author: otethal

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -1207,7 +1207,7 @@ Object generic(VirtualFrame frame, Object wSource, Object wFilename, Object wMod
                 }
                 checkOptimize(optimize, kwOptimize);
             }
-            if (getCore().isCoreInitialized() && AstModuleBuiltins.isAst(getContext(), wSource)) {
+            if (AstModuleBuiltins.isAst(getContext(), wSource)) {
                 ModTy mod = AstModuleBuiltins.obj2sst(getContext(), wSource);
                 // TODO _PyAST_Validate
                 Source source = createFakeSource();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ast/AstModuleBuiltins.java

@@ -98,6 +98,11 @@ public void initialize(Python3Core core) {
         clsAst.setAttribute(T__FIELDS, emptyTuple);
         clsAst.setAttribute(T__ATTRIBUTES, emptyTuple);
         // TODO clsAst.setAttribute('__match_args__', emptyTuple);
+    }
+
+    @Override
+    public void postInitialize(Python3Core core) {
+        super.postInitialize(core);
         PythonModule astModule = core.lookupBuiltinModule(T__AST);
         AstTypeFactory astTypeFactory = new AstTypeFactory(core.getLanguage(), core.factory(), astModule);
         AstState state = new AstState(astTypeFactory, core.lookupType(PythonBuiltinClassType.AST));
@@ -108,7 +113,8 @@ public void initialize(Python3Core core) {
 
     private void createBackwardCompatibilityClasses(Python3Core core, PythonModule astModule, AstState state) {
         // ast.py from cpython 3.10.5 defines classes for backwards compatibility
-        // As long as we are still using ast.py from 3.8.6, we need to provide these classes somehow.
+        // As long as we are still using ast.py from 3.8.6, we need to provide these classes
+        // somehow.
         PythonLanguage language = core.getLanguage();
         PythonObjectFactory factory = core.factory();
 
@@ -146,6 +152,9 @@ public static ModTy obj2sst(PythonContext context, Object obj) {
 
     @TruffleBoundary
     public static boolean isAst(PythonContext context, Object obj) {
-        return Obj2SstBase.isInstanceOf(obj, getAstState(context).clsAst);
+        // We need to look up the ast.AST class in the context and cannot rely on the cached value
+        // in AstState.clsAst because this method is called from compile() which may be called
+        // before postInitialize().
+        return Obj2SstBase.isInstanceOf(obj, context.lookupType(PythonBuiltinClassType.AST));
     }
 }