[GR-47994] Fix creating datetime objects when platform access is denied.

Author: steve-s

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/advance/ExclusionsTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -41,11 +41,26 @@
 package com.oracle.graal.python.test.advance;
 
 import org.graalvm.polyglot.Context;
+import org.junit.Test;
 
 public class ExclusionsTest {
     public static void main(String[] args) {
         try (Context context = Context.create()) {
             context.eval("python", "print('Hello Python!');");
         }
     }
+
+    @Test
+    public void testDatetimeWithoutPlatformAccess() {
+        if (!"true".equals(System.getProperty("python.WithoutPlatformAccess"))) {
+            return;
+        }
+        var builder = Context.newBuilder().allowExperimentalOptions(true);
+        if (System.getenv("GRAAL_PYTHONHOME") != null) {
+            builder.option("python.PythonHome", System.getenv("GRAAL_PYTHONHOME"));
+        }
+        try (Context context = builder.build()) {
+            context.eval("python", "import datetime; datetime.datetime.strptime('2014 7 2 6 14 0 742 +0700', '%Y %m %d %H %M %S %f %z')");
+        }
+    }
 }

graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/advance/ResourcesTest.java

@@ -43,7 +43,9 @@
 import static org.junit.Assert.assertTrue;
 
 import java.io.File;
+
 import org.graalvm.polyglot.Context;
+import org.graalvm.polyglot.io.IOAccess;
 import org.junit.Test;
 
 public class ResourcesTest {
@@ -59,4 +61,12 @@ public void testResourcesAsHome() {
             assertTrue(foundHome, !foundHome.contains("graalpython"));
         }
     }
+
+    @Test
+    public void testResourcesAlwaysAllowReading() {
+        try (Context context = Context.newBuilder("python").allowIO(IOAccess.NONE).option("python.PythonHome", "/path/that/does/not/exist").build()) {
+            String foundHome = context.eval("python", "import email; email.__spec__.origin").asString();
+            assertTrue(foundHome, foundHome.contains("python" + File.separator + "python-home"));
+        }
+    }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/TimeModuleBuiltins.java

@@ -325,7 +325,7 @@ Object tzset() {
                 }
                 TimeZone.setDefault(TimeZone.getTimeZone(tzEnv));
             } else {
-                PRaiseNode.raiseUncached(this, PythonBuiltinClassType.SystemError, SET_TIMEZONE_ERROR);
+                PRaiseNode.raiseUncached(this, PythonBuiltinClassType.AttributeError, SET_TIMEZONE_ERROR);
             }
             return PNone.NONE;
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java

@@ -1665,6 +1665,7 @@ private void initializePosixSupport() {
     }
 
     private TruffleString langHome, sysPrefix, basePrefix, coreHome, capiHome, jniHome, stdLibHome;
+    private TruffleFile homeResourcesFile;
 
     public void initializeHomeAndPrefixPaths(Env newEnv, String languageHome) {
         if (ImageInfo.inImageBuildtimeCode()) {
@@ -1704,7 +1705,8 @@ public void initializeHomeAndPrefixPaths(Env newEnv, String languageHome) {
                         () -> {
                             if (PythonLanguage.PYTHON_RESOURCE_CLASS != null && !ImageInfo.inImageCode()) {
                                 try {
-                                    return newEnv.getInternalResource(PythonLanguage.PYTHON_RESOURCE_CLASS).getAbsoluteFile();
+                                    homeResourcesFile = newEnv.getInternalResource(PythonLanguage.PYTHON_RESOURCE_CLASS).getAbsoluteFile();
+                                    return homeResourcesFile;
                                 } catch (IOException e) {
                                     // fall through
                                 }
@@ -2274,6 +2276,15 @@ void releaseGil() {
      */
     @TruffleBoundary
     public TruffleFile getPublicTruffleFileRelaxed(TruffleString path, TruffleString... allowedSuffixes) {
+        if (homeResourcesFile != null && !env.isFileIOAllowed()) {
+            // XXX: Workaround for Truffle resources not being considered internal truffle files
+            String jlPath = path.toJavaStringUncached();
+            String jlHome = langHome.toJavaStringUncached();
+            if (jlPath.startsWith(jlHome)) {
+                String homeRelativePath = jlPath.substring(jlHome.length() + 1);
+                return homeResourcesFile.resolve(homeRelativePath);
+            }
+        }
         TruffleFile f = env.getInternalTruffleFile(path.toJavaStringUncached());
         // 'isDirectory' does deliberately not follow symlinks because otherwise this could allow to
         // escape the language home directory.

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonOptions.java

@@ -139,7 +139,7 @@ private PythonOptions() {
     }
 
     @Option(category = OptionCategory.EXPERT, help = "Set the home of Python. Equivalent of GRAAL_PYTHONHOME env variable. " +
-                    "Determines default values for the CoreHome, StdLibHome, SysBasePrefix, SysPrefix.", usageSyntax = "<path>", stability = OptionStability.EXPERIMENTAL) //
+                    "Determines default values for the CoreHome, StdLibHome, SysBasePrefix, SysPrefix.", usageSyntax = "<path>", stability = OptionStability.STABLE) //
     public static final OptionKey<String> PythonHome = new OptionKey<>("");
 
     @Option(category = OptionCategory.USER, help = "Set the location of sys.prefix. Overrides any environment variables or Java options.", usageSyntax = "<path>", stability = OptionStability.STABLE) //

mx.graalpython/mx_graalpython.py

@@ -1412,6 +1412,14 @@ def graalpython_gate_runner(args, tasks):
                 )
             else:
                 punittest(['--verbose'], report=report())
+                # Run tests with static exclusion paths
+                jdk = mx.get_jdk()
+                prev = jdk.java_args_pfx
+                try:
+                    jdk.java_args_pfx = (mx._opts.java_args or []) + ['-Dpython.WithoutPlatformAccess=true']
+                    punittest(['--verbose', '--no-leak-tests', '--regex', 'com.oracle.graal.python.test.advance.ExclusionsTest'])
+                finally:
+                    jdk.java_args_pfx = prev
 
     # Unittests on JVM
     with Task('GraalPython Python unittests', tasks, tags=[GraalPythonTags.unittest]) as task: