better return types in SliceLiteralNode (also works around GR-28840)

lukasstadler · lukasstadler · commit 7c6b6c15d983 · 2021-02-23T11:16:30.000+01:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/subscript/SliceLiteralNode.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/subscript/SliceLiteralNode.java
@@ -98,12 +98,12 @@ public PSlice doInt(PNone start, int stop, int step) {
 
     @Specialization(guards = {"isNoValue(second)", "isNoValue(third)"})
     @SuppressWarnings("unused")
-    public Object sliceStop(int first, PNone second, PNone third) {
+    public PSlice sliceStop(int first, PNone second, PNone third) {
         return factory.createIntSlice(0, first, 1, true, true);
     }
 
     @Specialization(guards = {"!isNoValue(stop)", "!isNoValue(step)"})
-    public Object doGeneric(Object start, Object stop, Object step) {
+    public PSlice doGeneric(Object start, Object stop, Object step) {
         return factory.createObjectSlice(start, stop, step);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -98,12 +98,12 @@ public PSlice doInt(PNone start, int stop, int step) {`
`98`	`98`
`99`	`99`	`@Specialization(guards = {"isNoValue(second)", "isNoValue(third)"})`
`100`	`100`	`@SuppressWarnings("unused")`
`101`		`- public Object sliceStop(int first, PNone second, PNone third) {`
	`101`	`+ public PSlice sliceStop(int first, PNone second, PNone third) {`
`102`	`102`	`return factory.createIntSlice(0, first, 1, true, true);`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`@Specialization(guards = {"!isNoValue(stop)", "!isNoValue(step)"})`
`106`		`- public Object doGeneric(Object start, Object stop, Object step) {`
	`106`	`+ public PSlice doGeneric(Object start, Object stop, Object step) {`
`107`	`107`	`return factory.createObjectSlice(start, stop, step);`
`108`	`108`	`}`
`109`	`109`