Use fast identity check node in guards of 'LookupAttributeInMRONode'.

Author: fangerer

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/TypeNodes.java

@@ -541,15 +541,29 @@ private static PythonAbstractClass[] cast(Object[] arr) {
     @ImportStatic(SpecialMethodNames.class)
     public abstract static class IsSameTypeNode extends PNodeWithContext {
 
+        protected final boolean fastCheck;
+
+        public IsSameTypeNode(boolean fastCheck) {
+            this.fastCheck = fastCheck;
+        }
+
         public abstract boolean execute(Object left, Object right);
 
         @Specialization
         boolean doManaged(PythonManagedClass left, PythonManagedClass right) {
             return left == right;
         }
 
-        @Specialization
-        boolean doNative(PythonAbstractNativeObject left, PythonAbstractNativeObject right,
+        @Specialization(guards = "fastCheck")
+        boolean doNativeFast(PythonAbstractNativeObject left, PythonAbstractNativeObject right) {
+            // This check is a bit dangerous since we cannot be sure about the code that is running.
+            // Currently, we assume that the pointer object is a Sulong pointer and for this it's
+            // fine.
+            return left.object.equals(right.object);
+        }
+
+        @Specialization(guards = "!fastCheck")
+        boolean doNativeSlow(PythonAbstractNativeObject left, PythonAbstractNativeObject right,
                         @Cached("create(__EQ__)") CExtNodes.PointerCompareNode pointerCompareNode) {
             return pointerCompareNode.execute(left, right);
         }
@@ -570,7 +584,11 @@ public static boolean doSlowPath(Object left, Object right) {
         }
 
         public static IsSameTypeNode create() {
-            return IsSameTypeNodeGen.create();
+            return IsSameTypeNodeGen.create(false);
+        }
+
+        public static IsSameTypeNode createFast() {
+            return IsSameTypeNodeGen.create(true);
         }
 
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/LookupAttributeInMRONode.java

@@ -44,6 +44,7 @@
 import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.type.LazyPythonClass;
 import com.oracle.graal.python.builtins.objects.type.PythonAbstractClass;
+import com.oracle.graal.python.builtins.objects.type.TypeNodes;
 import com.oracle.graal.python.builtins.objects.type.TypeNodes.GetMroNode;
 import com.oracle.graal.python.builtins.objects.type.TypeNodes.GetMroStorageNode;
 import com.oracle.graal.python.nodes.PNodeWithContext;
@@ -96,6 +97,7 @@ protected Object lookup(PythonAbstractClass klass, Object key,
     }
 
     protected final String key;
+    @Child private TypeNodes.IsSameTypeNode isSameTypeNode = TypeNodes.IsSameTypeNode.createFast();
     @Child private GetMroStorageNode getMroNode;
 
     public LookupAttributeInMRONode(String key) {
@@ -168,7 +170,7 @@ protected PythonClassAssumptionPair findAttrClassAndAssumptionInMRO(PythonAbstra
         return new PythonClassAssumptionPair(attrAssumption, PNone.NO_VALUE);
     }
 
-    @Specialization(guards = {"klass == cachedKlass", "cachedClassInMROInfo != null"}, limit = "getIntOption(getContext(), AttributeAccessInlineCacheMaxDepth)", assumptions = {
+    @Specialization(guards = {"isSameType(cachedKlass, klass)", "cachedClassInMROInfo != null"}, limit = "getIntOption(getContext(), AttributeAccessInlineCacheMaxDepth)", assumptions = {
                     "cachedClassInMROInfo.assumption"})
     protected Object lookupConstantMROCached(@SuppressWarnings("unused") PythonAbstractClass klass,
                     @Cached("klass") @SuppressWarnings("unused") PythonAbstractClass cachedKlass,
@@ -184,7 +186,7 @@ protected ReadAttributeFromObjectNode[] create(int size) {
         return nodes;
     }
 
-    @Specialization(guards = {"klass == cachedKlass", "mroLength < 32"}, limit = "getIntOption(getContext(), AttributeAccessInlineCacheMaxDepth)", assumptions = "lookupStable")
+    @Specialization(guards = {"isSameType(cachedKlass, klass)", "mroLength < 32"}, limit = "getIntOption(getContext(), AttributeAccessInlineCacheMaxDepth)", assumptions = "lookupStable")
     @ExplodeLoop(kind = ExplodeLoop.LoopExplosionKind.FULL_EXPLODE_UNTIL_RETURN)
     protected Object lookupConstantMRO(@SuppressWarnings("unused") PythonAbstractClass klass,
                     @Cached("klass") @SuppressWarnings("unused") PythonAbstractClass cachedKlass,
@@ -243,4 +245,8 @@ public static Object lookupSlow(LazyPythonClass klass, String key) {
         }
         return PNone.NO_VALUE;
     }
+
+    protected boolean isSameType(PythonAbstractClass cachedKlass, PythonAbstractClass klass) {
+        return isSameTypeNode.execute(cachedKlass, klass);
+    }
 }