throw error on nonempty slots and itemsize > 0

Author: tomasstupka

graalpython/com.oracle.graal.python.test/src/tests/test_slot.py

@@ -151,5 +151,13 @@ class C(A, B): __slots__ = ["__dict__", "__dict__"]
         with self.assertRaisesRegex(TypeError, '__weakref__ slot disallowed: either we already got one, or __itemsize__ != 0'):
             class C(A, B): __slots__ = ["__weakref__", "__weakref__"]
 
+    def test_itemsize_and_non_empty_slots(self):
+        raised = False
+        try:
+            class C(tuple): __slots__ = ['a']
+        except TypeError:
+            raised = True
+        assert raised        
+        
 if __name__ == "__main__":
     unittest.main()

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -2293,6 +2293,10 @@ private PythonClass typeMetaclass(VirtualFrame frame, String name, PTuple bases,
                 }
                 int slotlen = getListLenNode().execute(slotsStorage);
 
+                if (slotlen > 0 && hasItemSize) {
+                    throw raise(TypeError, ErrorMessages.NONEMPTY_SLOTS_NOT_ALLOWED_FOR_SUBTYPE_OF_S, base);
+                }
+
                 for (int i = 0; i < slotlen; i++) {
                     String slotName;
                     Object element = getSlotItemNode().execute(frame, slotsStorage, i);