Add exception handling to atexit runner

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_atexit.txt

@@ -3,6 +3,7 @@
 *graalpython.lib-python.3.test.test_atexit.GeneralTest.test_clear
 *graalpython.lib-python.3.test.test_atexit.GeneralTest.test_exit
 *graalpython.lib-python.3.test.test_atexit.GeneralTest.test_order
+*graalpython.lib-python.3.test.test_atexit.GeneralTest.test_raise
 *graalpython.lib-python.3.test.test_atexit.GeneralTest.test_unregister
 *graalpython.lib-python.3.test.test_atexit.SubinterpreterTest.test_callback_on_subinterpreter_teardown
 *graalpython.lib-python.3.test.test_atexit.SubinterpreterTest.test_callbacks_leak

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/AtexitModuleBuiltins.java

@@ -150,8 +150,11 @@ int get() {
     abstract static class RunExitfuncsNode extends PythonBuiltinNode {
         @Specialization
         Object run() {
-            getContext().runAtexitHooks();
-            getContext().clearAtexitHooks();
+            try {
+                getContext().runAtexitHooks();
+            } finally {
+                getContext().clearAtexitHooks();
+            }
             return PNone.NONE;
         }
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java

@@ -50,6 +50,8 @@
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.logging.Level;
 
+import com.oracle.graal.python.builtins.PythonBuiltinClassType;
+import com.oracle.graal.python.nodes.object.IsBuiltinClassProfile;
 import org.graalvm.collections.EconomicMap;
 import org.graalvm.collections.MapCursor;
 import org.graalvm.nativeimage.ImageInfo;
@@ -742,6 +744,7 @@ public int getAtexitHookCount() {
 
     @TruffleBoundary
     public void runAtexitHooks() {
+        // run atExitHooks in reverse order they were registered
         MapCursor<Object, AtExitHook> cursor = atExitHooks.getEntries();
         AtExitHook[] hooks = new AtExitHook[atExitHooks.size()];
         Object[] callables = new Object[atExitHooks.size()];
@@ -750,16 +753,31 @@ public void runAtexitHooks() {
             callables[i] = cursor.getKey();
             hooks[i] = cursor.getValue();
         }
+        PException lastException = null;
         for (int i = hooks.length - 1; i >= 0; i--) {
-            hooks[i].ct.call(callables[i], hooks[i].arguments, hooks[i].keywords);
+            try {
+                hooks[i].ct.call(callables[i], hooks[i].arguments, hooks[i].keywords);
+            } catch (PException e) {
+                lastException = e;
+                if (!IsBuiltinClassProfile.profileClassSlowPath(e.getEscapedException(), PythonBuiltinClassType.SystemExit)) {
+                    System.err.println("Error in atexit._run_exitfuncs:");
+                    ExceptionUtils.printPythonLikeStackTrace(e);
+                }
+            }
+        }
+        if (lastException != null) {
+            throw lastException;
         }
     }
 
     @TruffleBoundary
     public void runShutdownHooks() {
         handler.shutdown();
-        // run atExitHooks in reverse order they were registered
-        runAtexitHooks();
+        try {
+            runAtexitHooks();
+        } catch (PException e) {
+            // It was printed already, so just discard
+        }
         for (ShutdownHook h : shutdownHooks) {
             h.call(this);
         }