Avoid specific upcall for PySequence_Check and PyMapping_Check

Author: msimacek

graalpython/com.oracle.graal.python.cext/src/abstract.c

@@ -1687,10 +1687,6 @@ PyNumber_ToBase(PyObject *n, int base)
 int
 PySequence_Check(PyObject *s)
 {
-    // GraalPy change: upcall for managed
-    if (points_to_py_handle_space(s)) {
-        return GraalPyTruffleSequence_Check(s);
-    }
     if (PyDict_Check(s))
         return 0;
     return Py_TYPE(s)->tp_as_sequence &&
@@ -2297,10 +2293,6 @@ PySequence_Index(PyObject *s, PyObject *o)
 int
 PyMapping_Check(PyObject *o)
 {
-    // GraalPy change: upcall for managed
-    if (points_to_py_handle_space(o)) {
-        return GraalPyTruffleMapping_Check(o);
-    }
     return o && Py_TYPE(o)->tp_as_mapping &&
         Py_TYPE(o)->tp_as_mapping->mp_subscript;
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextAbstractBuiltins.java

@@ -52,7 +52,6 @@
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.PyObjectTransfer;
 import static com.oracle.graal.python.builtins.objects.cext.capi.transitions.ArgDescriptor.Py_ssize_t;
 import static com.oracle.graal.python.builtins.objects.cext.structs.CFields.PyTypeObject__tp_doc;
-import static com.oracle.graal.python.builtins.objects.ints.PInt.intValue;
 import static com.oracle.graal.python.nodes.BuiltinNames.T_SEND;
 import static com.oracle.graal.python.nodes.ErrorMessages.BASE_MUST_BE;
 import static com.oracle.graal.python.nodes.ErrorMessages.OBJ_ISNT_MAPPING;
@@ -103,7 +102,6 @@
 import com.oracle.graal.python.lib.GetNextNode;
 import com.oracle.graal.python.lib.PyIndexCheckNode;
 import com.oracle.graal.python.lib.PyIterCheckNode;
-import com.oracle.graal.python.lib.PyMappingCheckNode;
 import com.oracle.graal.python.lib.PyNumberCheckNode;
 import com.oracle.graal.python.lib.PyNumberFloatNode;
 import com.oracle.graal.python.lib.PyNumberIndexNode;
@@ -680,16 +678,6 @@ static Object run(Object o, Object i,
         }
     }
 
-    @CApiBuiltin(ret = Int, args = {PyObject}, call = Ignored)
-    abstract static class PyTruffleSequence_Check extends CApiUnaryBuiltinNode {
-        @Specialization
-        static int check(Object object,
-                        @Bind("this") Node inliningTarget,
-                        @Cached PySequenceCheckNode check) {
-            return intValue(check.execute(inliningTarget, object));
-        }
-    }
-
     @CApiBuiltin(ret = PyObjectTransfer, args = {PyObject, Py_ssize_t}, call = Ignored)
     abstract static class PyTruffleSequence_GetItem extends CApiBinaryBuiltinNode {
         @Specialization
@@ -882,17 +870,6 @@ static Object values(Object obj,
         }
     }
 
-    @CApiBuiltin(ret = Int, args = {PyObject}, call = Direct)
-    abstract static class PyTruffleMapping_Check extends CApiUnaryBuiltinNode {
-
-        @Specialization
-        static int doPythonObject(Object object,
-                        @Bind("this") Node inliningTarget,
-                        @Cached PyMappingCheckNode checkNode) {
-            return intValue(checkNode.execute(inliningTarget, object));
-        }
-    }
-
     @CApiBuiltin(ret = Py_ssize_t, args = {PyObject}, call = Ignored)
     abstract static class PyTruffleMapping_Size extends CApiUnaryBuiltinNode {