[GR-17517] Implement a few gc module stubs for timeit module

PullRequest: graalpython/607

Author: timfel

CHANGELOG.md

@@ -5,6 +5,7 @@ language runtime. The main focus is on user-observable behavior of the engine.
 
 ## Version 19.3.0
 
+* Implement `gc.{enable,disable,isenabled}` as stubs
 * Implement `charmap_build` function
 * Implement `hexversion` in sys module
 * Implement `_lzma` module
@@ -13,6 +14,7 @@ language runtime. The main focus is on user-observable behavior of the engine.
 * Fix destructuring assignments of arbitrary iterators
 * Fix `dict.__contains__` for dictionaries with only `str` keys for subclasses of `str`
 * Support NumPy 1.16.4 and Pandas 0.25.0
+* Support `timeit` module
 * Support importing Java classes using normal Python import syntax when the package is known
 * Improve performance across many Python benchmarks
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/GcModuleBuiltins.java

@@ -32,6 +32,7 @@
 import com.oracle.graal.python.builtins.Builtin;
 import com.oracle.graal.python.builtins.CoreFunctions;
 import com.oracle.graal.python.builtins.PythonBuiltins;
+import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.cext.PythonNativeClass;
 import com.oracle.graal.python.builtins.objects.cext.PythonNativeObject;
 import com.oracle.graal.python.builtins.objects.tuple.PTuple;
@@ -50,11 +51,11 @@ protected List<com.oracle.truffle.api.dsl.NodeFactory<? extends PythonBuiltinNod
         return GcModuleBuiltinsFactory.getFactories();
     }
 
-    @Builtin(name = "collect", minNumOfPositionalArgs = 0)
+    @Builtin(name = "collect", minNumOfPositionalArgs = 0, maxNumOfPositionalArgs = 1)
     @GenerateNodeFactory
     abstract static class GcCollectNode extends PythonBuiltinNode {
         @Specialization
-        int collect(VirtualFrame frame) {
+        int collect(VirtualFrame frame, @SuppressWarnings("unused") Object level) {
             doGc();
             // collect some weak references now
             getContext().triggerAsyncActions(frame, this);
@@ -67,6 +68,32 @@ private static void doGc() {
         }
     }
 
+    @Builtin(name = "isenabled", minNumOfPositionalArgs = 0)
+    @GenerateNodeFactory
+    abstract static class GcIsEnabledNode extends PythonBuiltinNode {
+        @Specialization
+        boolean isenabled() {
+            return true;
+        }
+    }
+
+    abstract static class StubNode extends PythonBuiltinNode {
+        @Specialization
+        PNone disable() {
+            return PNone.NONE;
+        }
+    }
+
+    @Builtin(name = "disable", minNumOfPositionalArgs = 0)
+    @GenerateNodeFactory
+    abstract static class DisableNode extends StubNode {
+    }
+
+    @Builtin(name = "enable", minNumOfPositionalArgs = 0)
+    @GenerateNodeFactory
+    abstract static class EnableNode extends StubNode {
+    }
+
     @Builtin(name = "get_count", minNumOfPositionalArgs = 0)
     @GenerateNodeFactory
     abstract static class GcCountNode extends PythonBuiltinNode {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/attributes/ReadAttributeFromDynamicObjectNode.java

@@ -81,11 +81,6 @@ protected static boolean checkShape(@SuppressWarnings("unused") DynamicObject dy
         return cachedObject.getShape() == cachedShape;
     }
 
-    private static boolean assertFinal(DynamicObject dynamicObject, Object key, Object cachedValue) {
-        Object other = dynamicObject.get(key) == null ? PNone.NO_VALUE : dynamicObject.get(key);
-        return cachedValue == other || cachedValue instanceof Number && other instanceof Number && ((Number) cachedValue).doubleValue() == ((Number) other).doubleValue();
-    }
-
     @SuppressWarnings("unused")
     @Specialization(limit = "1", //
                     guards = {
@@ -110,7 +105,6 @@ protected Object readDirectFinal(DynamicObject dynamicObject, Object key,
                     @Cached("loc.getFinalAssumption()") Assumption finalAssumption,
                     @SuppressWarnings("unused") @Cached("singleContextAssumption()") Assumption singleContextAssumption,
                     @Cached("readFinalValue(dynamicObject, loc)") Object cachedValue) {
-        assert assertFinal(dynamicObject, attrKey, cachedValue);
         return cachedValue;
     }