Allow creating tracebacks from python code

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinConstructors.java

@@ -136,6 +136,7 @@
 import com.oracle.graal.python.builtins.objects.set.SetNodes;
 import com.oracle.graal.python.builtins.objects.str.PString;
 import com.oracle.graal.python.builtins.objects.superobject.SuperObject;
+import com.oracle.graal.python.builtins.objects.traceback.PTraceback;
 import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.builtins.objects.type.LazyPythonClass;
 import com.oracle.graal.python.builtins.objects.type.PythonAbstractClass;
@@ -189,6 +190,7 @@
 import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.runtime.PythonCore;
 import com.oracle.graal.python.runtime.exception.PException;
+import com.oracle.graal.python.runtime.object.PythonObjectFactory;
 import com.oracle.graal.python.runtime.sequence.PSequence;
 import com.oracle.graal.python.runtime.sequence.storage.ByteSequenceStorage;
 import com.oracle.graal.python.runtime.sequence.storage.ObjectSequenceStorage;
@@ -2827,12 +2829,40 @@ Object call() {
         }
     }
 
-    @Builtin(name = "traceback", constructsClass = PythonBuiltinClassType.PTraceback, isPublic = false)
+    @Builtin(name = "TracebackType", constructsClass = PythonBuiltinClassType.PTraceback, isPublic = false, minNumOfPositionalArgs = 5, parameterNames = {"$cls", "tb_next", "tb_frame", "tb_lasti",
+                    "tb_lineno"})
     @GenerateNodeFactory
     public abstract static class TracebackTypeNode extends PythonBuiltinNode {
-        @Specialization
-        Object call() {
-            throw raise(RuntimeError, ErrorMessages.CANNOT_CALL_CTOR_OF, "traceback type");
+        @Specialization(limit = "1")
+        Object createTraceback(@SuppressWarnings("unused") LazyPythonClass cls, PTraceback next, PFrame frame, Object lasti, Object lineno,
+                        @CachedLibrary("lasti") PythonObjectLibrary lastiLib,
+                        @CachedLibrary("lineno") PythonObjectLibrary linenoLib,
+                        @Cached PythonObjectFactory factory) {
+            return factory.createTraceback(frame, linenoLib.asSize(lineno), lastiLib.asSize(lasti), next);
+        }
+
+        @Specialization(limit = "1")
+        Object createTraceback(@SuppressWarnings("unused") LazyPythonClass cls, @SuppressWarnings("unused") PNone next, PFrame frame, Object lasti, Object lineno,
+                        @CachedLibrary("lasti") PythonObjectLibrary lastiLib,
+                        @CachedLibrary("lineno") PythonObjectLibrary linenoLib,
+                        @Cached PythonObjectFactory factory) {
+            return factory.createTraceback(frame, linenoLib.asSize(lineno), lastiLib.asSize(lasti), null);
+        }
+
+        @Specialization(guards = {"!isPTraceback(next)", "!isNone(next)"})
+        @SuppressWarnings("unused")
+        Object errorNext(LazyPythonClass cls, Object next, Object frame, Object lasti, Object lineno) {
+            throw raise(TypeError, "expected traceback object or None, got '%p'", next);
+        }
+
+        @Specialization(guards = "!isPFrame(frame)")
+        @SuppressWarnings("unused")
+        Object errorFrame(LazyPythonClass cls, Object next, Object frame, Object lasti, Object lineno) {
+            throw raise(TypeError, "TracebackType() argument 'tb_frame' must be frame, not %p", frame);
+        }
+
+        protected static boolean isPFrame(Object obj) {
+            return obj instanceof PFrame;
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/traceback/PTraceback.java

@@ -50,13 +50,19 @@ public final class PTraceback extends PythonBuiltinObject {
     private PFrame frame;
     private PFrame.Reference frameInfo;
     private int lineno = -2;
+    private int lasti;
     private PTraceback next;
     private LazyTraceback lazyTraceback;
 
     public PTraceback(PFrame frame, int lineno, PTraceback next) {
+        this(frame, lineno, -1, next);
+    }
+
+    public PTraceback(PFrame frame, int lineno, int lasti, PTraceback next) {
         super(PythonBuiltinClassType.PTraceback, PythonBuiltinClassType.PTraceback.newInstance());
         this.frame = frame;
         this.lineno = lineno;
+        this.lasti = lasti;
         this.next = next;
     }
 
@@ -83,6 +89,10 @@ public int getLineno() {
         return lineno;
     }
 
+    public int getLasti() {
+        return lasti;
+    }
+
     public LazyTraceback getLazyTraceback() {
         return lazyTraceback;
     }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/traceback/TracebackBuiltins.java

@@ -299,8 +299,8 @@ Object setError(@SuppressWarnings("unused") PTraceback self, Object next) {
     @GenerateNodeFactory
     public abstract static class GetTracebackLastINode extends PythonBuiltinNode {
         @Specialization
-        Object get(@SuppressWarnings("unused") PTraceback self) {
-            return -1;
+        Object get(PTraceback self) {
+            return self.getLasti();
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/object/PythonObjectFactory.java

@@ -618,6 +618,10 @@ public PTraceback createTraceback(PFrame frame, int lineno, PTraceback next) {
         return trace(new PTraceback(frame, lineno, next));
     }
 
+    public PTraceback createTraceback(PFrame frame, int lineno, int lasti, PTraceback next) {
+        return trace(new PTraceback(frame, lineno, lasti, next));
+    }
+
     public PTraceback createTraceback(LazyTraceback tb) {
         return trace(new PTraceback(tb));
     }