Don't free native wrappers before finalizers are called

Author: msimacek

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiContext.java

@@ -446,6 +446,18 @@ public Object execute(VirtualFrame frame) {
                     startTime = System.currentTimeMillis();
                 }
 
+                /*
+                 * Note about the order of operations - we need to call the finalizers first before
+                 * removing the objects from the wrapper list because the finalizers may still make
+                 * upcalls and those need the wrappers to work correctly.
+                 */
+
+                callBulkSubref.call(NativeCAPISymbol.FUN_BULK_SUBREF, new PointerArrayWrapper(nativeObjectReferences), new RefCountArrayWrapper(nativeObjectReferences), (long) n);
+
+                if (loggable) {
+                    middleTime = System.currentTimeMillis();
+                }
+
                 if (LOGGER.isLoggable(Level.FINER)) {
                     // it's not an OSR loop, so we do this before the loop
                     if (n > 0 && pointerObjectLib == null) {
@@ -474,12 +486,6 @@ public Object execute(VirtualFrame frame) {
                     }
                 }
 
-                if (loggable) {
-                    middleTime = System.currentTimeMillis();
-                }
-
-                callBulkSubref.call(NativeCAPISymbol.FUN_BULK_SUBREF, new PointerArrayWrapper(nativeObjectReferences), new RefCountArrayWrapper(nativeObjectReferences), (long) n);
-
                 if (loggable) {
                     final long countDuration = middleTime - startTime;
                     final long duration = System.currentTimeMillis() - middleTime;