Fixed handling of non-integer types in math.factorial() as expected by test_math.py

otethal · otethal · commit 87a21092bdec · 2020-06-01T16:34:56.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MathModuleBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MathModuleBuiltins.java
@@ -488,7 +488,7 @@ public Object factorialPFL(PFloat value) {
         public Object factorialObject(VirtualFrame frame, Object value,
                         @CachedLibrary("value") PythonObjectLibrary lib,
                         @Cached("create()") FactorialNode recursiveNode) {
-            return recursiveNode.execute(frame, lib.asPInt(value));
+            return recursiveNode.execute(frame, lib.asIndex(value));
         }
 
         protected boolean isInteger(double value) {

Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ public Object factorialPFL(PFloat value) {`
`488`	`488`	`public Object factorialObject(VirtualFrame frame, Object value,`
`489`	`489`	`@CachedLibrary("value") PythonObjectLibrary lib,`
`490`	`490`	`@Cached("create()") FactorialNode recursiveNode) {`
`491`		`- return recursiveNode.execute(frame, lib.asPInt(value));`
	`491`	`+ return recursiveNode.execute(frame, lib.asIndex(value));`
`492`	`492`	`}`
`493`	`493`
`494`	`494`	`protected boolean isInteger(double value) {`