add support for non string keys to function's __dict__

Author: cosminbasca

graalpython/com.oracle.graal.python.test/src/tests/test_dict.py

@@ -441,4 +441,5 @@ def bar():
 
     bar.__dict__[1] = 1
     bar.a = 'a'
-    assert bar.__dict__ == {1: 1, 'a': 'a'}
+    assert 1 in bar.__dict__
+    assert 'a' in bar.__dict__

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/HashingStorageNodes.java

@@ -489,6 +489,11 @@ protected boolean updateShape(DynamicObjectStorage storage, String name) {
             return readUncached(storage, name);
         }
 
+        @Specialization(guards = "!isJavaString(name)")
+        protected boolean readUncached(PythonObjectHybridDictStorage storage, Object name) {
+            return storage.hasKey(name, getEquivalence());
+        }
+
         @Specialization(guards = "!isJavaString(name)")
         @SuppressWarnings("unused")
         protected boolean readUncached(DynamicObjectStorage storage, Object name) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -46,6 +46,7 @@
 import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.cell.PCell;
 import com.oracle.graal.python.builtins.objects.code.PCode;
+import com.oracle.graal.python.builtins.objects.dict.PDict;
 import com.oracle.graal.python.builtins.objects.module.PythonModule;
 import com.oracle.graal.python.builtins.objects.object.PythonObject;
 import com.oracle.graal.python.nodes.argument.CreateArgumentsNode;
@@ -234,7 +235,12 @@ Object builtinCode(PBuiltinFunction self, Object none) {
     static abstract class DictNode extends PythonUnaryBuiltinNode {
         @Specialization
         Object dict(PFunction self) {
-            return factory().createMappingproxy(self);
+            PDict dict = self.getDict();
+            if (dict == null) {
+                dict = factory().createDictFixedStorage(self);
+                self.setDict(dict);
+            }
+            return dict;
         }
 
         @SuppressWarnings("unused")