python threads: setting the stack size has no effect on thread creation, since the java thread stack size != python thread stack size

- python threads are created using the default jvm decided stack size

Author: cosminbasca

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ThreadModuleBuiltins.java

@@ -125,16 +125,7 @@ long getCount() {
     abstract static class GetThreadStackSizeNode extends PythonUnaryBuiltinNode {
         @Specialization
         long getStackSize(@SuppressWarnings("unused") PNone stackSize) {
-            return getContext().getThreadStackSize();
-        }
-
-        @Specialization
-        long getStackSize(int stackSize,
-                        @Cached("createBinaryProfile()") ConditionProfile invalidSizeProfile) {
-            if (invalidSizeProfile.profile(stackSize < 0)) {
-                throw raise(ValueError, "size must be 0 or a positive value");
-            }
-            return getContext().getAndSetThreadStackSize(stackSize);
+            return getContext().getPythonThreadStackSize();
         }
 
         @Specialization
@@ -143,7 +134,7 @@ long getStackSize(long stackSize,
             if (invalidSizeProfile.profile(stackSize < 0)) {
                 throw raise(ValueError, "size must be 0 or a positive value");
             }
-            return getContext().getAndSetThreadStackSize(stackSize);
+            return getContext().getAndSetPythonsThreadStackSize(stackSize);
         }
     }
 

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/thread/CreateThreadNode.java

@@ -67,7 +67,9 @@ public PThread execute(VirtualFrame frame, PythonClass cls, Object callable, Obj
         PythonContext context = getContext();
         TruffleContext truffleContext = context.getEnv().getContext();
 
-        return factory().createThread(cls, context.getThreadGroup(), context.getThreadStackSize(), () -> {
+        // TODO: python thread stack size != java thread stack size
+        // ignore setting the stack size for the moment
+        return factory().createThread(cls, context.getThreadGroup(), 0, () -> {
             Object previous = truffleContext.enter();
             Object[] arguments = getArgsNode.executeWith(args);
             PKeyword[] keywords = getKwArgsNode.executeWith(kwargs);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonContext.java

@@ -64,8 +64,9 @@ public final class PythonContext {
     private final HashMap<Object, CallTarget> atExitHooks = new HashMap<>();
     private final AtomicLong globalId = new AtomicLong(Integer.MAX_VALUE * 2L + 4L);
     private final ThreadGroup threadGroup = new ThreadGroup(GRAALPYTHON_THREADS);
-    private final AtomicLong threadStackSize = new AtomicLong(0); // the VM will set it to whatever
-                                                                  // it likes
+
+    // if set to 0 the VM will set it to whatever it likes
+    private final AtomicLong pythonThreadStackSize = new AtomicLong(0);
 
     @CompilationFinal private TruffleLanguage.Env env;
 
@@ -108,12 +109,12 @@ public ThreadGroup getThreadGroup() {
     }
 
     @TruffleBoundary(allowInlining = true)
-    public long getThreadStackSize() {
-        return threadStackSize.get();
+    public long getPythonThreadStackSize() {
+        return pythonThreadStackSize.get();
     }
 
-    public long getAndSetThreadStackSize(long value) {
-        return threadStackSize.getAndSet(value);
+    public long getAndSetPythonsThreadStackSize(long value) {
+        return pythonThreadStackSize.getAndSet(value);
     }
 
     @TruffleBoundary(allowInlining = true)