Skip to content

Commit 8d0a301

Browse files
steve-ssteve-s
committed
Inline PythonContext#getCore(), make ParserErrorCallback an abstract class
1 parent 01b95ee commit 8d0a301

File tree

66 files changed

+231
-236
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+231
-236
lines changed

‎graalpython/com.oracle.graal.python.benchmarks/java/com/oracle/graal/python/benchmarks/parser/ParserBenchRunner.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ public ParserBenchRunner() {
107107
context.enter();
108108

109109
this.pyContext = PythonContext.get(null);
110-
this.parser = (PythonParserImpl) pyContext.getCore().getParser();
111-
this.core = pyContext.getCore();
110+
this.parser = (PythonParserImpl) pyContext.getParser();
111+
this.core = pyContext;
112112
}
113113

114114
public static void main(String[] args) throws RunnerException {

‎graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/builtins/modules/ConversionNodeTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public boolean isPythonInternal() {
9696
}.getCallTarget();
9797
try {
9898
Object[] arguments = PArguments.create(1);
99-
PArguments.setGlobals(arguments, pythonContext.getCore().factory().createDict());
99+
PArguments.setGlobals(arguments, pythonContext.factory().createDict());
100100
PArguments.setException(arguments, PException.NO_EXCEPTION);
101101
PArguments.setArgument(arguments, 0, arg);
102102
PythonThreadState threadState = pythonContext.getThreadState(language);

‎graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/PythonTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ public static RootNode getParseResult(com.oracle.truffle.api.source.Source sourc
297297
PythonContext ctx = PythonContext.get(null);
298298
ctx.setOut(out);
299299
ctx.setErr(err);
300-
return (RootNode) ctx.getCore().getParser().parse(ParserMode.File, 0, ctx.getCore(), source, null, null);
300+
return (RootNode) ctx.getParser().parse(ParserMode.File, 0, ctx, source, null, null);
301301
} finally {
302302
closeContext();
303303
}

‎graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/parser/ParserTestBase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ protected Source createSource(File testFile) throws Exception {
113113

114114
public Node parse(String src, String moduleName, PythonParser.ParserMode mode, Frame fd) {
115115
Source source = Source.newBuilder(PythonLanguage.ID, src, moduleName).build();
116-
PythonParser parser = context.getCore().getParser();
117-
Node result = ((PythonParserImpl) parser).parseN(mode, 0, context.getCore(), source, fd, null);
116+
PythonParser parser = context.getParser();
117+
Node result = ((PythonParserImpl) parser).parseN(mode, 0, context, source, fd, null);
118118
lastGlobalScope = ((PythonParserImpl) parser).getLastGlobaScope();
119119
lastSST = ((PythonParserImpl) parser).getLastSST();
120120
return result;
@@ -125,8 +125,8 @@ public Node parse(String src, String moduleName, PythonParser.ParserMode mode) {
125125
}
126126

127127
public Node parse(Source source, PythonParser.ParserMode mode) {
128-
PythonParser parser = context.getCore().getParser();
129-
Node result = ((PythonParserImpl) parser).parseN(mode, 0, context.getCore(), source, null, null);
128+
PythonParser parser = context.getParser();
129+
Node result = ((PythonParserImpl) parser).parseN(mode, 0, context, source, null, null);
130130
lastGlobalScope = ((PythonParserImpl) parser).getLastGlobaScope();
131131
lastSST = ((PythonParserImpl) parser).getLastSST();
132132
return result;

‎graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/parser/SSTSerializationTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,18 +1260,18 @@ public void checkSerialization(String code) throws Exception {
12601260
}
12611261

12621262
public void checkSerialization(Source source) throws Exception {
1263-
PythonCodeSerializer serializer = context.getCore().getSerializer();
1263+
PythonCodeSerializer serializer = context.getSerializer();
12641264

12651265
// at first parse the source and obtain the parse result
12661266
RootNode parserResult = (RootNode) parse(source, PythonParser.ParserMode.File);
12671267
ScopeInfo parserScope = getLastGlobalScope();
12681268
checkScopeSerialization(parserScope);
12691269
Assert.assertNotNull("Parser result is null", parserResult);
12701270
// serialize the source
1271-
byte[] serializeResult = serializer.serialize(context.getCore(), parserResult);
1271+
byte[] serializeResult = serializer.serialize(context, parserResult);
12721272
Assert.assertNotNull("Serialized data are null", serializeResult);
12731273
// and get the tree from serialized data
1274-
RootNode deserialize = serializer.deserialize(context.getCore(), serializeResult);
1274+
RootNode deserialize = serializer.deserialize(context, serializeResult);
12751275

12761276
Assert.assertNotNull("Deserialized result is null", parserResult);
12771277
// compare the tree from parser with the tree from serializer
@@ -1533,9 +1533,9 @@ public long[] getTimes(File file) throws Exception {
15331533
result[0] = end - startMemory;
15341534
result[3] = end - startFile;
15351535

1536-
PythonCodeSerializer serializer = context.getCore().getSerializer();
1536+
PythonCodeSerializer serializer = context.getSerializer();
15371537
startFile = System.nanoTime();
1538-
byte[] serializeResult = serializer.serialize(context.getCore(), parserResult);
1538+
byte[] serializeResult = serializer.serialize(context, parserResult);
15391539
end = System.nanoTime();
15401540
result[1] = end - startFile;
15411541
TruffleFile serFile = context.getEnv().getInternalTruffleFile(file.getAbsolutePath() + ".pyc");
@@ -1550,7 +1550,7 @@ public long[] getTimes(File file) throws Exception {
15501550
TruffleFile tFile = context.getEnv().getInternalTruffleFile(file.getAbsolutePath() + ".pyc");
15511551
byte[] desbytes = tFile.readAllBytes();
15521552
startMemory = System.nanoTime();
1553-
serializer.deserialize(context.getCore(), desbytes);
1553+
serializer.deserialize(context, desbytes);
15541554
end = System.nanoTime();
15551555
result[2] = end - startMemory;
15561556
result[5] = end - startFile;

‎graalpython/com.oracle.graal.python.test/src/com/oracle/graal/python/test/runtime/PythonModuleTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void tearDown() {
8989

9090
@Test
9191
public void pythonModuleTest() {
92-
PythonModule module = context.getCore().factory().createPythonModule("testModule");
92+
PythonModule module = context.factory().createPythonModule("testModule");
9393
assertEquals("testModule", module.getAttribute(__NAME__).toString());
9494
assertEquals("None", module.getAttribute(__DOC__).toString());
9595
assertEquals("None", module.getAttribute(__PACKAGE__).toString());

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ public static String getEvalMimeType(int optimize) {
374374
@Override
375375
protected CallTarget parse(ParsingRequest request) {
376376
PythonContext context = PythonContext.get(null);
377-
Python3Core core = context.getCore();
378377
Source source = request.getSource();
379378
if (source.getMimeType() == null || MIME_TYPE.equals(source.getMimeType())) {
380379
if (!request.getArgumentNames().isEmpty()) {
@@ -390,7 +389,7 @@ protected CallTarget parse(ParsingRequest request) {
390389
gil.release(context, wasAcquired);
391390
}
392391
}
393-
if (core.isCoreInitialized()) {
392+
if (context.isCoreInitialized()) {
394393
return PythonUtils.getOrCreateCallTarget(new TopLevelExceptionHandler(this, root, source));
395394
} else {
396395
return PythonUtils.getOrCreateCallTarget(root);
@@ -405,18 +404,18 @@ protected CallTarget parse(ParsingRequest request) {
405404
if (bytes.length == 0) {
406405
return createCachedCallTarget(l -> new BadOPCodeNode(l), BadOPCodeNode.class);
407406
}
408-
return PythonUtils.getOrCreateCallTarget(core.getSerializer().deserialize(core, bytes));
407+
return PythonUtils.getOrCreateCallTarget(context.getSerializer().deserialize(context, bytes));
409408
}
410409
for (int optimize = 0; optimize < MIME_TYPE_EVAL.length; optimize++) {
411410
if (MIME_TYPE_EVAL[optimize].equals(source.getMimeType())) {
412411
assert !source.isInteractive();
413-
return PythonUtils.getOrCreateCallTarget((RootNode) core.getParser().parse(ParserMode.Eval, optimize, core, source, null, null));
412+
return PythonUtils.getOrCreateCallTarget((RootNode) context.getParser().parse(ParserMode.Eval, optimize, context, source, null, null));
414413
}
415414
}
416415
for (int optimize = 0; optimize < MIME_TYPE_COMPILE.length; optimize++) {
417416
if (MIME_TYPE_COMPILE[optimize].equals(source.getMimeType())) {
418417
assert !source.isInteractive();
419-
return PythonUtils.getOrCreateCallTarget((RootNode) core.getParser().parse(ParserMode.File, optimize, core, source, null, null));
418+
return PythonUtils.getOrCreateCallTarget((RootNode) context.getParser().parse(ParserMode.File, optimize, context, source, null, null));
420419
}
421420
}
422421
throw CompilerDirectives.shouldNotReachHere("unknown mime type: " + source.getMimeType());
@@ -438,9 +437,8 @@ private RootNode doParse(PythonContext context, Source source, int optimize) {
438437
// by default we assume a module
439438
mode = ParserMode.File;
440439
}
441-
Python3Core pythonCore = context.getCore();
442440
try {
443-
return (RootNode) pythonCore.getParser().parse(mode, optimize, pythonCore, source, null, null);
441+
return (RootNode) context.getParser().parse(mode, optimize, context, source, null, null);
444442
} catch (PException e) {
445443
// handle PException during parsing (PIncompleteSourceException will propagate through)
446444
PythonUtils.getOrCreateCallTarget(new TopLevelExceptionHandler(this, e)).call();
@@ -493,7 +491,7 @@ public Object execute(VirtualFrame frame) {
493491

494492
private RootCallTarget parse(PythonContext context, VirtualFrame frame) {
495493
CompilerAsserts.neverPartOfCompilation();
496-
RootNode rootNode = (RootNode) context.getCore().getParser().parse(ParserMode.WithArguments, 0, context.getCore(), source, frame, argumentNames);
494+
RootNode rootNode = (RootNode) context.getParser().parse(ParserMode.WithArguments, 0, context, source, frame, argumentNames);
497495
return rootNode.getCallTarget();
498496
}
499497
};
@@ -555,8 +553,7 @@ private Object parseAndEval(PythonContext context, MaterializedFrame frame) {
555553

556554
@TruffleBoundary
557555
protected static ExpressionNode parseInline(Source code, PythonContext context, MaterializedFrame lexicalContextFrame) {
558-
Python3Core pythonCore = context.getCore();
559-
return (ExpressionNode) pythonCore.getParser().parse(ParserMode.InlineEvaluation, 0, pythonCore, code, lexicalContextFrame, null);
556+
return (ExpressionNode) context.getParser().parse(ParserMode.InlineEvaluation, 0, context, code, lexicalContextFrame, null);
560557
}
561558

562559
@Override
@@ -567,9 +564,9 @@ protected Object getLanguageView(PythonContext context, Object value) {
567564
try {
568565
if (interopLib.isBoolean(value)) {
569566
if (interopLib.asBoolean(value)) {
570-
return context.getCore().getTrue();
567+
return context.getTrue();
571568
} else {
572-
return context.getCore().getFalse();
569+
return context.getFalse();
573570
}
574571
} else if (interopLib.isString(value)) {
575572
return factory.createString(interopLib.asString(value));
@@ -717,7 +714,7 @@ public static Source newSource(PythonContext ctxt, TruffleFile src, String name)
717714
}
718715

719716
private static Source newSource(PythonContext ctxt, SourceBuilder srcBuilder) throws IOException {
720-
boolean coreIsInitialized = ctxt.getCore().isCoreInitialized();
717+
boolean coreIsInitialized = ctxt.isCoreInitialized();
721718
boolean internal = !coreIsInitialized && !ctxt.getLanguage().getEngineOption(PythonOptions.ExposeInternalSources);
722719
if (internal) {
723720
srcBuilder.internal(true);

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/Python3Core.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@
285285
* types. The core is embedded, using inheritance, into {@link PythonContext} to avoid indirection
286286
* through an extra field in the context.
287287
*/
288-
public abstract class Python3Core implements ParserErrorCallback {
288+
public abstract class Python3Core extends ParserErrorCallback {
289289
private static final TruffleLogger LOGGER = PythonLanguage.getLogger(Python3Core.class);
290290
private final String[] coreFiles;
291291

@@ -625,7 +625,8 @@ public Python3Core(PythonLanguage language, PythonParser parser, boolean isNativ
625625

626626
@Override
627627
public final PythonContext getContext() {
628-
// Small hack: we know that this is the only implementation of Python3Core
628+
// Small hack: we know that this is the only implementation of Python3Core, this should be
629+
// removed once and if Python3Core is fully merged into PythonContext
629630
return (PythonContext) this;
630631
}
631632

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@ public final Shape getInstanceShape(PythonLanguage lang) {
718718
@ExportMessage
719719
public Object send(Message message, Object[] args,
720720
@CachedLibrary(limit = "1") ReflectionLibrary lib) throws Exception {
721-
return lib.send(PythonContext.get(lib).getCore().lookupType(this), message, args);
721+
return lib.send(PythonContext.get(lib).lookupType(this), message, args);
722722
}
723723

724724
public static boolean isExceptionType(PythonBuiltinClassType type) {

‎graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/AtexitModuleBuiltins.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,11 @@ private static void handleException(PythonContext context, PException e) {
119119
PBaseException pythonException = e.getEscapedException();
120120
if (!IsBuiltinClassProfile.profileClassSlowPath(GetClassNode.getUncached().execute(pythonException), PythonBuiltinClassType.SystemExit)) {
121121
PyObjectCallMethodObjArgs callWrite = PyObjectCallMethodObjArgs.getUncached();
122-
callWrite.execute(null, context.getCore().getStderr(), "write", "Error in atexit._run_exitfuncs:\n");
122+
callWrite.execute(null, context.getStderr(), "write", "Error in atexit._run_exitfuncs:\n");
123123
try {
124124
ExceptionUtils.printExceptionTraceback(context, pythonException);
125125
} catch (PException pe) {
126-
callWrite.execute(null, context.getCore().getStderr(), "write", "Failed to print traceback\n");
126+
callWrite.execute(null, context.getStderr(), "write", "Failed to print traceback\n");
127127
}
128128
}
129129
}

0 commit comments

Comments
 (0)