[GR-10596] bin function is not available.

Author: ppisl

graalpython/com.oracle.graal.python.test/src/tests/test_builtin.py

@@ -0,0 +1,27 @@
+# Copyright (c) 2018, Oracle and/or its affiliates.
+# Copyright (C) 1996-2017 Python Software Foundation
+#
+# Licensed under the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2
+    
+import unittest
+
+class MyIndexable(object):
+    def __init__(self, value):
+        self.value = value
+    def __index__(self):
+        return self.value
+
+class BuiltinTest(unittest.TestCase):
+    def test_bin(self):
+        self.assertEqual(bin(0), '0b0')
+        self.assertEqual(bin(1), '0b1')
+        self.assertEqual(bin(-1), '-0b1')
+        self.assertEqual(bin(2**65), '0b1' + '0' * 65)
+        self.assertEqual(bin(2**65-1), '0b' + '1' * 65)
+        self.assertEqual(bin(-(2**65)), '-0b1' + '0' * 65)
+        self.assertEqual(bin(-(2**65-1)), '-0b' + '1' * 65)
+
+        # test of specializations
+        self.assertEqual(bin(MyIndexable(False)), '0b0')
+        self.assertEqual(bin(MyIndexable(True)), '0b1')
+        self.assertEqual(bin(MyIndexable(-(2**65))), '-0b1' + '0' * 65)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -28,6 +28,7 @@
 import static com.oracle.graal.python.builtins.objects.PNone.NO_VALUE;
 import static com.oracle.graal.python.builtins.objects.PNotImplemented.NOT_IMPLEMENTED;
 import static com.oracle.graal.python.nodes.BuiltinNames.ABS;
+import static com.oracle.graal.python.nodes.BuiltinNames.BIN;
 import static com.oracle.graal.python.nodes.BuiltinNames.CALLABLE;
 import static com.oracle.graal.python.nodes.BuiltinNames.CHR;
 import static com.oracle.graal.python.nodes.BuiltinNames.COMPILE;
@@ -197,6 +198,54 @@ public Object absObject(Object object,
             return result;
         }
     }
+    
+    // bin(object)
+    @Builtin(name = BIN, fixedNumOfArguments = 1)
+    @TypeSystemReference(PythonArithmeticTypes.class)
+    @GenerateNodeFactory
+    public abstract static class BinNode extends PythonUnaryBuiltinNode {
+        
+        public abstract String executeObject(Object x);
+        
+        private String buildString(boolean isNegative, String number) {
+            StringBuilder sb = new StringBuilder();
+            if(isNegative) {
+                sb.append('-');
+            }
+            sb.append("0b");
+            sb.append(number);
+            return sb.toString();
+        }
+        
+        @Specialization
+        public String doL(long x) {
+            return buildString(x < 0, Long.toBinaryString(Math.abs(x)));
+        }
+        
+        @Specialization
+        public String doD(double x) {
+            throw raise(TypeError, "'%p' object cannot be interpreted as an integer", x);
+        }
+        
+        @Specialization
+        @TruffleBoundary
+        public String doPI(PInt x) {
+            BigInteger value = x.getValue();
+            return buildString(value.compareTo(BigInteger.ZERO) == -1, value.abs().toString(2));
+        }
+        
+        @Specialization
+        public String doO(Object x,
+                @Cached("create()") MathModuleBuiltins.ConvertToIntNode toIntNode,
+                @Cached("create()") BinNode recursiveNode) {
+            Object value = toIntNode.execute(x);
+            return recursiveNode.executeObject(value);
+        }
+        
+        protected BinNode create() {
+            return BuiltinFunctionsFactory.BinNodeFactory.create();
+        }
+    }
 
     // callable(object)
     @Builtin(name = CALLABLE, fixedNumOfArguments = 1)

mx.graalpython/copyrights/overrides

@@ -233,6 +233,7 @@ graalpython/com.oracle.graal.python.test/src/tests/test_getattribute-bimorphic-i
 graalpython/com.oracle.graal.python.test/src/tests/test_if-class-none.py,zippy.copyright
 graalpython/com.oracle.graal.python.test/src/tests/test_if.py,zippy.copyright
 graalpython/com.oracle.graal.python.test/src/tests/test_list.py,python.copyright
+graalpython/com.oracle.graal.python.test/src/tests/test_builtin.py,python.copyright
 graalpython/com.oracle.graal.python.test/src/tests/test_mandelbrot3.py,benchmarks.copyright
 graalpython/com.oracle.graal.python.test/src/tests/test_math.py,python.copyright
 graalpython/com.oracle.graal.python.test/src/tests/test_mm2d_naive.py,zippy.copyright