Skip to content

Commit 8f5c76b

Browse files
committed
gradle cleans generated resources if project folder was renamed,
so there is no need to check if our plugin took care of it
1 parent 9497d22 commit 8f5c76b

File tree

1 file changed

+54
-13
lines changed

1 file changed

+54
-13
lines changed

graalpython/com.oracle.graal.python.test/src/tests/standalone/test_gradle_plugin.py

Lines changed: 54 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ def generate_app(self, target_dir):
8989

9090
self.copy_build_files(target_dir)
9191

92-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
93-
def test_gradle_generated_app(self):
92+
def check_gradle_generated_app(self):
9493
with tempfile.TemporaryDirectory() as tmpdir:
9594
target_dir = os.path.join(str(tmpdir), "generated_app_gradle" + self.target_dir_name_sufix())
9695
self.generate_app(target_dir)
@@ -154,11 +153,9 @@ def test_gradle_generated_app(self):
154153
cmd = gradlew_cmd2 + ["build", "run"]
155154
out, return_code = util.run_cmd(cmd, self.env, cwd=target_dir2, gradle = True)
156155
util.check_ouput("BUILD SUCCESS", out)
157-
util.check_ouput("Deleting GraalPy venv due to broken launcher symlinks", out)
158156
util.check_ouput("hello java", out)
159157

160-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
161-
def test_gradle_generated_app_external_resources(self):
158+
def check_gradle_generated_app_external_resources(self):
162159
with tempfile.TemporaryDirectory() as tmpdir:
163160
target_dir = os.path.join(str(tmpdir), "generated_gradle_app_external_resources" + self.target_dir_name_sufix())
164161
self.generate_app(target_dir)
@@ -214,8 +211,7 @@ def test_gradle_generated_app_external_resources(self):
214211
out, return_code = util.run_cmd(cmd, self.env, cwd=target_dir)
215212
util.check_ouput("hello java", out)
216213

217-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
218-
def test_gradle_fail_without_graalpy_dep(self):
214+
def check_gradle_fail_without_graalpy_dep(self):
219215
with tempfile.TemporaryDirectory() as tmpdir:
220216
target_dir = os.path.join(str(tmpdir), "gradle_fail_without_graalpy_dep" + self.target_dir_name_sufix())
221217
self.generate_app(target_dir)
@@ -232,8 +228,7 @@ def test_gradle_fail_without_graalpy_dep(self):
232228
out, return_code = util.run_cmd(cmd, self.env, cwd=target_dir, gradle = True)
233229
util.check_ouput("Missing GraalPy dependency. Please add to your build.gradle either org.graalvm.polyglot:python-community or org.graalvm.polyglot:python", out)
234230

235-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
236-
def test_gradle_gen_launcher_and_venv(self):
231+
def check_gradle_gen_launcher_and_venv(self):
237232
with tempfile.TemporaryDirectory() as tmpdir:
238233
target_dir = os.path.join(str(tmpdir), "gradle_gen_launcher_and_venv" + self.target_dir_name_sufix())
239234
self.generate_app(target_dir)
@@ -275,8 +270,7 @@ def check_tagfile(self, home, expected):
275270
lines = f.readlines()
276271
assert lines == expected, "expected tagfile " + str(expected) + ", but got " + str(lines)
277272

278-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
279-
def test_gradle_check_home(self):
273+
def check_gradle_check_home(self):
280274
with tempfile.TemporaryDirectory() as tmpdir:
281275
target_dir = os.path.join(str(tmpdir), "check_home_test" + self.target_dir_name_sufix())
282276
self.generate_app(target_dir)
@@ -344,8 +338,7 @@ def test_gradle_check_home(self):
344338
assert line.endswith("/__init__.py"), f"expected line to end with /__init__.py, but was '{line}'"
345339
assert not line.endswith("html/__init__.py"), f"expected line to end with html/__init__.py, but was '{line}''"
346340

347-
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
348-
def test_gradle_empty_packages(self):
341+
def check_gradle_empty_packages(self):
349342
with tempfile.TemporaryDirectory() as tmpdir:
350343
target_dir = os.path.join(str(tmpdir), "empty_packages_test" + self.target_dir_name_sufix())
351344
self.generate_app(target_dir)
@@ -365,6 +358,30 @@ def setUpClass(self):
365358
self.build_file_name = "build.gradle"
366359
self.settings_file_name = "settings.gradle"
367360

361+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
362+
def test_gradle_generated_app(self):
363+
self.check_gradle_generated_app()
364+
365+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
366+
def test_gradle_generated_app_external_resources(self):
367+
self.check_gradle_generated_app_external_resources()
368+
369+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
370+
def test_gradle_fail_without_graalpy_dep(self):
371+
self.check_gradle_fail_without_graalpy_dep()
372+
373+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
374+
def test_gradle_gen_launcher_and_venv(self):
375+
self.check_gradle_gen_launcher_and_venv()
376+
377+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
378+
def test_gradle_check_home(self):
379+
self.check_gradle_check_home()
380+
381+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
382+
def test_gradle_empty_packages(self):
383+
self.check_gradle_empty_packages()
384+
368385
def target_dir_name_sufix(self):
369386
return "_groovy"
370387

@@ -439,6 +456,30 @@ def setUpClass(self):
439456
self.build_file_name = "build.gradle.kts"
440457
self.settings_file_name = "settings.gradle.kts"
441458

459+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
460+
def test_gradle_generated_app(self):
461+
self.check_gradle_generated_app()
462+
463+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
464+
def test_gradle_generated_app_external_resources(self):
465+
self.check_gradle_generated_app_external_resources()
466+
467+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
468+
def test_gradle_fail_without_graalpy_dep(self):
469+
self.check_gradle_fail_without_graalpy_dep()
470+
471+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
472+
def test_gradle_gen_launcher_and_venv(self):
473+
self.check_gradle_gen_launcher_and_venv()
474+
475+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
476+
def test_gradle_check_home(self):
477+
self.check_gradle_check_home()
478+
479+
@unittest.skipUnless(util.is_gradle_plugin_test_enabled, "ENABLE_GRADLE_PLUGIN_UNITTESTS is not true")
480+
def test_gradle_empty_packages(self):
481+
self.check_gradle_empty_packages()
482+
442483
def target_dir_name_sufix(self):
443484
return "_kotlin"
444485

0 commit comments

Comments
 (0)