always call both directions for comparison operations

Author: timfel

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_binop.txt

@@ -1,4 +1,5 @@
 *graalpython.lib-python.3.test.test_binop.FallbackBlockingTests.test_fallback_ne_blocking
+*graalpython.lib-python.3.test.test_binop.OperationOrderTests.test_comparison_orders
 *graalpython.lib-python.3.test.test_binop.RatTestCase.test_add
 *graalpython.lib-python.3.test.test_binop.RatTestCase.test_constructor
 *graalpython.lib-python.3.test.test_binop.RatTestCase.test_div

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/call/special/LookupAndCallBinaryNode.java

@@ -74,6 +74,7 @@ public abstract static class NotImplementedHandler extends PNodeWithContext {
     protected final String name;
     protected final String rname;
     protected final Supplier<NotImplementedHandler> handlerFactory;
+    private final boolean alwaysCheckReverse;
 
     @Child private CallBinaryMethodNode dispatchNode;
     @Child private CallBinaryMethodNode reverseDispatchNode;
@@ -103,27 +104,32 @@ public abstract static class NotImplementedHandler extends PNodeWithContext {
 
     public abstract Object executeObject(VirtualFrame frame, Object arg, Object arg2);
 
-    LookupAndCallBinaryNode(String name, String rname, Supplier<NotImplementedHandler> handlerFactory) {
+    LookupAndCallBinaryNode(String name, String rname, Supplier<NotImplementedHandler> handlerFactory, boolean alwaysCheckReverse) {
         this.name = name;
         this.rname = rname;
         this.handlerFactory = handlerFactory;
+        this.alwaysCheckReverse = alwaysCheckReverse;
     }
 
     public static LookupAndCallBinaryNode create(String name) {
-        return LookupAndCallBinaryNodeGen.create(name, null, null);
+        return LookupAndCallBinaryNodeGen.create(name, null, null, false);
     }
 
     public static LookupAndCallBinaryNode createReversible(String name, String reverseName, Supplier<NotImplementedHandler> handlerFactory) {
         assert name.startsWith("__") && reverseName.startsWith("__r");
-        return LookupAndCallBinaryNodeGen.create(name, reverseName, handlerFactory);
+        return LookupAndCallBinaryNodeGen.create(name, reverseName, handlerFactory, false);
     }
 
     public static LookupAndCallBinaryNode create(String name, String rname) {
-        return LookupAndCallBinaryNodeGen.create(name, rname, null);
+        return LookupAndCallBinaryNodeGen.create(name, rname, null, false);
+    }
+
+    public static LookupAndCallBinaryNode create(String name, String rname, boolean alwaysCheckReverse) {
+        return LookupAndCallBinaryNodeGen.create(name, rname, null, alwaysCheckReverse);
     }
 
     public static LookupAndCallBinaryNode create(String name, String rname, Supplier<NotImplementedHandler> handlerFactory) {
-        return LookupAndCallBinaryNodeGen.create(name, rname, handlerFactory);
+        return LookupAndCallBinaryNodeGen.create(name, rname, handlerFactory, false);
     }
 
     protected Object getMethod(Object receiver, String methodName) {
@@ -316,7 +322,7 @@ Object callObject(VirtualFrame frame, Object left, Object right,
         Object leftCallable = getattr.execute(leftClass);
         Object rightClass = libRight.getLazyPythonClass(right);
         Object rightCallable = getattrR.execute(rightClass);
-        if (leftCallable == rightCallable) {
+        if (!alwaysCheckReverse && leftCallable == rightCallable) {
             rightCallable = PNone.NO_VALUE;
         }
         if (leftCallable != PNone.NO_VALUE) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/expression/BinaryComparisonNode.java

@@ -56,7 +56,8 @@ public abstract class BinaryComparisonNode extends BinaryOpNode {
         this.magicMethod = magicMethod;
         this.magicReverseMethod = magicReverseMethod;
         this.operation = operation;
-        this.callNode = LookupAndCallBinaryNode.create(magicMethod, magicReverseMethod);
+        // see cpython://Objects/object.c#do_richcompare - CPython always calls the reverse method
+        this.callNode = LookupAndCallBinaryNode.create(magicMethod, magicReverseMethod, true);
     }
 
     public static BinaryComparisonNode create(String magicMethod, String magicReverseMethod, String operation, ExpressionNode left, ExpressionNode right) {