Skip to content

Commit 93ae2c1

Browse files
committed
remove obsolete options
1 parent 5fb993a commit 93ae2c1

File tree

4 files changed

+6
-42
lines changed

4 files changed

+6
-42
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/builtins/ListNodes.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
import com.oracle.graal.python.nodes.control.GetNextNode;
6969
import com.oracle.graal.python.nodes.object.GetClassNode;
7070
import com.oracle.graal.python.nodes.truffle.PythonArithmeticTypes;
71-
import com.oracle.graal.python.runtime.PythonOptions;
7271
import com.oracle.graal.python.runtime.exception.PException;
7372
import com.oracle.graal.python.runtime.exception.PythonErrorType;
7473
import com.oracle.graal.python.runtime.sequence.PSequence;
@@ -102,11 +101,7 @@ public final static class CreateListFromIteratorNode extends PBaseNode {
102101

103102
private final ConditionProfile errorProfile = ConditionProfile.createBinaryProfile();
104103

105-
@CompilationFinal private ListStorageType type;
106-
107-
public CreateListFromIteratorNode() {
108-
this.type = PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceStorage) ? ListStorageType.Uninitialized : ListStorageType.Generic;
109-
}
104+
@CompilationFinal private ListStorageType type = ListStorageType.Uninitialized;
110105

111106
public static CreateListFromIteratorNode create() {
112107
return new CreateListFromIteratorNode();

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/control/GetIteratorNode.java

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import com.oracle.graal.python.nodes.control.GetIteratorNodeGen.IsIteratorObjectNodeGen;
4747
import com.oracle.graal.python.nodes.expression.UnaryOpNode;
4848
import com.oracle.graal.python.nodes.object.GetClassNode;
49-
import com.oracle.graal.python.runtime.PythonOptions;
5049
import com.oracle.graal.python.runtime.exception.PException;
5150
import com.oracle.graal.python.runtime.sequence.PSequence;
5251
import com.oracle.truffle.api.CompilerDirectives;
@@ -94,38 +93,22 @@ public PythonObject doPRange(PRange value) {
9493

9594
@Specialization(guards = "iterCannotBeOverridden(value)")
9695
public PythonObject doPIntArray(PIntArray value) {
97-
if (PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceIteration)) {
98-
return factory().createIntArrayIterator(value);
99-
} else {
100-
return factory().createSequenceIterator(value);
101-
}
96+
return factory().createIntArrayIterator(value);
10297
}
10398

10499
@Specialization(guards = "iterCannotBeOverridden(value)")
105100
public PythonObject doPLongArray(PLongArray value) {
106-
if (PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceIteration)) {
107-
return factory().createLongArrayIterator(value);
108-
} else {
109-
return factory().createSequenceIterator(value);
110-
}
101+
return factory().createLongArrayIterator(value);
111102
}
112103

113104
@Specialization(guards = "iterCannotBeOverridden(value)")
114105
public PythonObject doPDoubleArray(PDoubleArray value) {
115-
if (PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceIteration)) {
116-
return factory().createDoubleArrayIterator(value);
117-
} else {
118-
return factory().createSequenceIterator(value);
119-
}
106+
return factory().createDoubleArrayIterator(value);
120107
}
121108

122109
@Specialization(guards = "iterCannotBeOverridden(value)")
123110
public PythonObject doCharArray(PCharArray value) {
124-
if (PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceIteration)) {
125-
return factory().createCharArrayIterator(value);
126-
} else {
127-
return factory().createSequenceIterator(value);
128-
}
111+
return factory().createCharArrayIterator(value);
129112
}
130113

131114
@Specialization(guards = "iterCannotBeOverridden(value)")

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/literal/ListLiteralNode.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import com.oracle.graal.python.builtins.objects.list.PList;
3131
import com.oracle.graal.python.builtins.objects.tuple.PTuple;
3232
import com.oracle.graal.python.nodes.PNode;
33-
import com.oracle.graal.python.runtime.PythonOptions;
3433
import com.oracle.graal.python.runtime.sequence.storage.DoubleSequenceStorage;
3534
import com.oracle.graal.python.runtime.sequence.storage.IntSequenceStorage;
3635
import com.oracle.graal.python.runtime.sequence.storage.ListSequenceStorage;
@@ -49,11 +48,10 @@ public final class ListLiteralNode extends LiteralNode {
4948

5049
@Children protected final PNode[] values;
5150

52-
@CompilationFinal private ListStorageType type;
51+
@CompilationFinal private ListStorageType type = ListStorageType.Uninitialized;
5352

5453
public ListLiteralNode(PNode[] values) {
5554
this.values = values;
56-
this.type = PythonOptions.getOption(getContext(), PythonOptions.UnboxSequenceStorage) ? ListStorageType.Uninitialized : ListStorageType.Generic;
5755
}
5856

5957
public PNode[] getValues() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonOptions.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,6 @@ private PythonOptions() {
4646
@Option(category = OptionCategory.DEBUG, help = "Print the java stacktrace if enabled") //
4747
public static final OptionKey<Boolean> WithJavaStacktrace = new OptionKey<>(false);
4848

49-
@Option(category = OptionCategory.DEBUG, help = "") //
50-
public static final OptionKey<Boolean> TraceSequenceStorageGeneralization = new OptionKey<>(false);
51-
52-
@Option(category = OptionCategory.DEBUG, help = "") //
53-
public static final OptionKey<Boolean> UnboxSequenceStorage = new OptionKey<>(true);
54-
55-
@Option(category = OptionCategory.DEBUG, help = "") //
56-
public static final OptionKey<Boolean> UnboxSequenceIteration = new OptionKey<>(true);
57-
5849
@Option(category = OptionCategory.DEBUG, help = "") //
5950
public static final OptionKey<Boolean> IntrinsifyBuiltinCalls = new OptionKey<>(true);
6051

@@ -76,9 +67,6 @@ private PythonOptions() {
7667
@Option(category = OptionCategory.DEBUG, help = "") //
7768
public static final OptionKey<Boolean> CatchGraalPythonExceptionForUnitTesting = new OptionKey<>(false);
7869

79-
@Option(category = OptionCategory.DEBUG, help = "") //
80-
public static final OptionKey<Boolean> ForceLongType = new OptionKey<>(false);
81-
8270
@Option(category = OptionCategory.DEBUG, help = "") //
8371
public static final OptionKey<Boolean> CatchAllExceptions = new OptionKey<>(false);
8472

0 commit comments

Comments
 (0)