Implement unicodedata.east_asian_width()

Author: andrykonchin

graalpython/com.oracle.graal.python.test/src/tests/test_unicodedata.py

@@ -75,3 +75,16 @@ def test_lookup(self):
         with self.assertRaisesRegex(KeyError, "name too long"):
             unicodedata.lookup("a" * 257)
 
+
+    def test_east_asian_width(self):
+        list = [1, 2, 3]
+        with self.assertRaisesRegex(TypeError, r"east_asian_width\(\) argument must be a unicode character, not list"):
+            unicodedata.east_asian_width(list)
+
+        multi_character_string = "abc"
+        with self.assertRaisesRegex(TypeError, r"east_asian_width\(\) argument must be a unicode character, not str"):
+            unicodedata.east_asian_width(multi_character_string)
+
+        empty_string = ""
+        with self.assertRaisesRegex(TypeError, r"east_asian_width\(\) argument must be a unicode character, not str"):
+            unicodedata.east_asian_width(empty_string)

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/UnicodeDataModuleBuiltins.java

@@ -40,6 +40,7 @@
  */
 package com.oracle.graal.python.builtins.modules;
 
+import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 import static com.oracle.graal.python.nodes.BuiltinNames.J_UNICODEDATA;
 import static com.oracle.graal.python.nodes.BuiltinNames.T_UNICODEDATA;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.KeyError;
@@ -50,6 +51,10 @@
 import java.util.List;
 
 import com.oracle.graal.python.builtins.objects.module.PythonModule;
+import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
+import com.oracle.graal.python.nodes.util.CastToTruffleStringNode;
+import com.oracle.truffle.api.strings.TruffleString.CodePointAtByteIndexNode;
+import com.oracle.truffle.api.strings.TruffleString.CodePointLengthNode;
 import com.oracle.truffle.api.strings.TruffleString.FromJavaStringNode;
 import com.oracle.truffle.api.strings.TruffleString.ToJavaStringNode;
 import org.graalvm.shadowed.com.ibm.icu.lang.UCharacter;
@@ -327,4 +332,52 @@ protected ArgumentClinicProvider getArgumentClinic() {
             return UnicodeDataModuleBuiltinsClinicProviders.CategoryNodeClinicProviderGen.INSTANCE;
         }
     }
+
+    // unicode.east_asia_width(chr)
+    @Builtin(name = "east_asian_width", minNumOfPositionalArgs = 1, numOfPositionalOnlyArgs = 1, parameterNames = {"chr"})
+    @GenerateNodeFactory
+    public abstract static class EastAsianWidthNode extends PythonUnaryBuiltinNode {
+        @Specialization
+        @TruffleBoundary
+        static TruffleString eastAsianWidth(Object object,
+                        @Bind Node inliningTarget,
+                        @Cached CastToTruffleStringNode castToTruffleStringNode,
+                        @Cached CodePointLengthNode codePointLengthNode,
+                        @Cached CodePointAtByteIndexNode codePointAtByteIndexNode,
+                        @Cached FromJavaStringNode fromJavaStringNode) {
+            final TruffleString chr;
+
+            try {
+                chr = CastToTruffleStringNode.getUncached().execute(inliningTarget, object);
+            } catch (CannotCastException e) {
+                throw PRaiseNode.raiseStatic(inliningTarget, TypeError, ErrorMessages.S_ARG_MUST_BE_S_NOT_P, "east_asian_width()", "a unicode character", object);
+            }
+
+            if (CodePointLengthNode.getUncached().execute(chr, TS_ENCODING) != 1) {
+                throw PRaiseNode.raiseStatic(inliningTarget, TypeError, ErrorMessages.S_ARG_MUST_BE_S_NOT_P, "east_asian_width()", "a unicode character", object);
+            }
+
+            int codepoint = CodePointAtByteIndexNode.getUncached().execute(chr, 0, TS_ENCODING);
+            String widthName = getWidthName(codepoint);
+            return fromJavaStringNode.execute(widthName, TS_ENCODING);
+        }
+
+        @TruffleBoundary
+        private static String getWidthName(int codepoint) {
+            int widthNameCode = UCharacter.getIntPropertyValue(codepoint, UProperty.EAST_ASIAN_WIDTH);
+            String widthName;
+
+            switch (widthNameCode) {
+                case UCharacter.EastAsianWidth.AMBIGUOUS -> widthName = "A";
+                case UCharacter.EastAsianWidth.FULLWIDTH -> widthName = "F";
+                case UCharacter.EastAsianWidth.HALFWIDTH -> widthName = "H";
+                case UCharacter.EastAsianWidth.NARROW -> widthName = "Na";
+                case UCharacter.EastAsianWidth.NEUTRAL -> widthName = "N";
+                case UCharacter.EastAsianWidth.WIDE -> widthName = "W";
+                default -> widthName = ""; // EastAsianWidth.COUNT
+            }
+
+            return widthName;
+        }
+    }
 }

graalpython/lib-graalpython/unicodedata.py

@@ -40,6 +40,6 @@
 __graalpython__.import_current_as_named_module_with_delegate(
     module_name="unicodedata",
     delegate_name="_cpython_unicodedata",
-    delegate_attributes=['ucd_3_2_0', 'east_asian_width', 'combining'],
+    delegate_attributes=['ucd_3_2_0', 'combining'],
     wrap_methods=False,
     owner_globals=globals())