Cleanup: remove some dead code, use lib.asPointer in CreateFunctionNode

Author: steve-s

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CExtNodes.java

@@ -2087,7 +2087,7 @@ static PythonObject doNativeCallableWithWrapper(TruffleString name, Object calla
                 // PyTypeObject slot field
                 TpSlotPython newSlot = pythonSlot.forNewType(type);
                 try {
-                    Object wrapper = context.getCApiContext().getClosureExecutable(InteropLibrary.getUncached().asPointer(callable));
+                    Object wrapper = context.getCApiContext().getClosureExecutable(lib.asPointer(callable));
                     if (wrapper instanceof TpSlotWrapper slotWrapper) {
                         TpSlotWrapper newWrapper = newSlot != pythonSlot ? slotWrapper.cloneWith(newSlot) : slotWrapper;
                         newWrapper.toNative(SignatureLibrary.getUncached());

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/TpSlots.java

@@ -116,11 +116,10 @@
 import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.strings.TruffleString;
-import com.oracle.truffle.nfi.api.SignatureLibrary;
 
 /**
  * Wraps fields that hold slot values, instances of {@link TpSlot}, such as {@link #tp_getattr()}.
- * This is GraalPython equivalent of the same fields in CPython's {@code PyTypeObject}.
+ * This is GraalPy equivalent of the same fields in CPython's {@code PyTypeObject}.
  * <p>
  * Summary of the interactions:
  * 
@@ -469,7 +468,6 @@ public static TpSlots createEmpty() {
      */
     public static TpSlots fromNative(PythonAbstractNativeObject pythonClass, PythonContext ctx) {
         var builder = TpSlots.newBuilder();
-        var signatureLib = SignatureLibrary.getUncached();
         for (TpSlotMeta def : TpSlotMeta.VALUES) {
             if (!def.hasNativeWrapperFactory()) {
                 continue;
@@ -576,7 +574,7 @@ public static void inherit(PythonClass klass, MroSequenceStorage mro) {
         Builder klassSlots = newBuilder();
         for (int i = 0; i < mro.length(); i++) {
             PythonAbstractClass type = mro.getItemNormalized(i);
-            TpSlots slots = GetTpSlotsNodeGen.getUncached().execute(null, type);
+            TpSlots slots = GetTpSlotsNode.executeUncached(type);
             assert slots != null || type == klass;
             if (slots != null) {
                 klassSlots.inherit(slots);

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/util/PythonUtils.java

@@ -134,8 +134,6 @@ private PythonUtils() {
      */
     public static final TruffleString.Encoding TS_ENCODING = TruffleString.Encoding.UTF_32;
 
-    public static final TruffleString EMPTY_TRUFFLESTRING = tsLiteral("");
-
     public static final String[] EMPTY_STRING_ARRAY = new String[0];
     public static final TruffleString[] EMPTY_TRUFFLESTRING_ARRAY = new TruffleString[0];
     public static final Object[] EMPTY_OBJECT_ARRAY = new Object[0];